Last Comment Bug 762263 - Add EGLSync
: Add EGLSync
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Jeff Gilbert [:jgilbert]
:
Mentors:
Depends on: 762265
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-06 15:12 PDT by Jeff Gilbert [:jgilbert]
Modified: 2012-06-13 05:58 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (8.77 KB, patch)
2012-06-06 16:02 PDT, Jeff Gilbert [:jgilbert]
jacob.benoit.1: review+
Details | Diff | Review

Description Jeff Gilbert [:jgilbert] 2012-06-06 15:12:20 PDT
We need EGLSync for sychronizing between contexts without 'sharing' them, particularly for EGLImage work.
Comment 1 Jeff Gilbert [:jgilbert] 2012-06-06 16:02:34 PDT
Created attachment 630753 [details] [diff] [review]
patch

Add EGLSync support.
Comment 2 Benoit Jacob [:bjacob] (mostly away) 2012-06-11 10:52:29 PDT
Comment on attachment 630753 [details] [diff] [review]
patch

Review of attachment 630753 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLDefs.h
@@ +3261,5 @@
> +#define LOCAL_EGL_SIGNALED                    0x30F2
> +#define LOCAL_EGL_UNSIGNALED                  0x30F3
> +#define LOCAL_EGL_SYNC_PRIOR_COMMANDS_COMPLETE  0x30F0
> +#define LOCAL_EGL_SYNC_FLUSH_COMMANDS_BIT     0x0001
> +#define LOCAL_EGL_FOREVER                     0xFFFFFFFFFFFFFFFFull

Is this a swear word?
Comment 3 Jeff Gilbert [:jgilbert] 2012-06-11 16:12:45 PDT
I hate these long constants. I am always suspicious they have the wrong number of Fs.
Comment 5 Ed Morley [:emorley] 2012-06-13 05:58:42 PDT
https://hg.mozilla.org/mozilla-central/rev/26a6e89c1efa

Note You need to log in before you can comment on or make changes to this bug.