762265 - Modernize EGL extension detection, similar to GLContext's IsExtensionSupported

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

We're going to be in EGL land on an increasing number of platforms, and working more with extensions for EGL for EGLImage, EGLSync, and hopefully eventually EGLStream.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: patch

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: patch

Adds NS_ERRORs when the extensions are 'supported', but their functions are not exposed.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 630739 [details] [diff] [review]
patch

Review of attachment 630739 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.cpp
@@ +539,5 @@
>  #else
>      const bool once = true;
>  #endif
>  
> +    mAvailableExtensions.Load(extensions, sExtensionNames, !once);

To remove the negation here and generally be more explicit, maybe you could use a |firstTime| variable here.

::: gfx/gl/GLContext.h
@@ +1568,2 @@
>          bool& operator[](size_t index) {
> +            NS_ASSERTION(index < Size, "out of range");

This should be a MOZ_ASSERT similar to bug 732607.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: patch with nits fixed

Carrying forward r+ with nit fixes.

Comment 5

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/27d0a3ecfe95

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/27d0a3ecfe95

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 632051 [details] [diff] [review]
patch with nits fixed

[Approval Request Comment]
Required by bug 728524

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 632051 [details] [diff] [review]
patch with nits fixed

Approving supporting patches for bug 687267

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-beta/rev/69b1dee11b5e