762264 - Help->About SeaMonkey page should link to about:rights and SeaMonkey privacy policy

Status: ASSIGNED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

Both Firefox and Thunderbird link to about:rights and privacy policy from their respective Help->About pages so I guess SeaMonkey should.
Should be fairly simple to achieve.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Add about:rights and Privacy Policy to Help->About (v1)

Comment 2

[:aceman]

Could you spell "End User Rights" in the same way bug 761443 mentions?

Comment 3

[Edmund Wong (:ewong)]

(In reply to :aceman from comment #2)
> Could you spell "End User Rights" in the same way bug 761443 mentions?

ahh.. ok.

Comment 4

[Edmund Wong (:ewong)]

Attachment: Add about:rights and Privacy Policy to Help->About (v2)

s/End User/End-User/

Comment 5

[Frank Wein [:mcsmurf]]

We have no official privacy policy yet, can we wait with this? It's still a draft and it's currently being worked on.

Comment 6

[:aceman]

Will it be any different to the Firefox+Thunderbird versions? Can't you link to those?

Comment 7

[[e-mail]]

Comment on attachment 630874 [details] [diff] [review]
Add about:rights and Privacy Policy to Help->About (v2)

>+      var privacyPolicyURL = formatter.formatURLPref("app.privacyPolicyURL");
> 
>       if (releaseNotesURL != "about:blank") {
>         var relnotes = document.getElementById("releaseNotesURL");
>         relnotes.setAttribute("href", releaseNotesURL);
>       }
> 
>+      if (privacyURL) {
Wrong variable name.
Nit: move the variable to before the if statement, instead of above the previous block, where it might get overlooked.
Nit: this block of code is in between the release nodes and vendor, although the pref and property strings have the privacy URL last. (You get to choose which is correct. Just to be confusing, the document order has the vendor first and the release nodes last!)

Please request some sort of approval on the final patch, so that it doesn't land until the link is ready.