762389 - de-ns-ify nsXULTreeAccessible and nsXULTreeGridAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 631202 [details] [diff] [review]
Patch (v1)

Review of attachment 631202 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thank you!

::: accessible/src/base/nsAccUtils.h
@@ +26,5 @@
>  class HyperTextAccessible;
>  class DocAccessible;
>  struct nsRoleMapEntry;
>  #ifdef MOZ_XUL
> +class XULTreeAccessible;

shouldn't it be namespaced?

::: accessible/src/generic/RootAccessible.cpp
@@ +54,3 @@
>  #include "nsIXULDocument.h"
>  #include "nsIXULWindow.h"
> +#include "XULTreeAccessible.h"

nit: you'd need to keep it with other accessible class files

::: accessible/src/msaa/Makefile.in
@@ +42,5 @@
>    ia2AccessibleHypertext.cpp \
>    ia2AccessibleRelation.cpp \
>    RootAccessibleWrap.cpp \
>    TextLeafAccessibleWrap.cpp \
> +  XULTreeGridAccessibleWrap.cpp \

shouldn't it be ifdefed by MOZ_XUL? (see src/Makefile.in)

::: accessible/src/msaa/nsXULTreeGridAccessibleWrap.cpp
@@ +34,5 @@
> +                                DocAccessible* aDoc,
> +                                XULTreeGridRowAccessible* aRowAcc,
> +                                nsITreeBoxObject* aTree,
> +                                nsITreeView* aTreeView,
> +                                 PRInt32 aRow, nsITreeColumn* aColumn) :

wrong indent

::: accessible/src/xul/nsXULTreeAccessible.cpp
@@ +1073,5 @@
>  }
>  
>  void
> +XULTreeItemAccessibleBase::GetCellName(nsITreeColumn* aColumn,
> +                                       nsAString& aName)

on the same line please

@@ +1181,4 @@
>  
>  void
> +XULTreeItemAccessible::RowInvalidated(PRInt32 aStartColIdx,
> +                                      PRInt32 aEndColIdx)

on the same line please

::: accessible/src/xul/nsXULTreeGridAccessible.cpp
@@ +398,5 @@
>  }
>  
>  NS_IMETHODIMP
> +XULTreeGridAccessible::IsColumnSelected(PRInt32 aColumnIndex,
> +                                          bool* aIsSelected)

on same line please

Comment 3

[Mark Capella [:capella]]

FYI ReL:

::: accessible/src/base/nsAccUtils.h
@@ +26,5 @@
>  class HyperTextAccessible;
>  class DocAccessible;
>  struct nsRoleMapEntry;
>  #ifdef MOZ_XUL
> +class XULTreeAccessible;

I forgot (again) to HG Refresh the Queue before posting ... the last thing I had to do to get the build working was remove the whole #ifdef / class XULTreefoo / #endif set of lines ... It caused an ambiguous reference error in nsaccessibilityservice.cpp ...

Comment 4

[Mark Capella [:capella]]

Attachment: Patch (v2)

Here's the patch with comments 2 / 3 addressed ... let me know if the makefile.in tweak looks ok?

Comment 5

[alexander :surkov (:asurkov)]

yes, thank you

Comment 6

[Mark Capella [:capella]]

Inbound TRY puss ...
https://tbpl.mozilla.org/?tree=Try&rev=783d249232b3

Comment 7

[Mark Capella [:capella]]

inbound push
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8d547fb468e7

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8d547fb468e7