Last Comment Bug 762389 - de-ns-ify nsXULTreeAccessible and nsXULTreeGridAccessible
: de-ns-ify nsXULTreeAccessible and nsXULTreeGridAccessible
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Mark Capella [:capella]
:
: alexander :surkov
Mentors:
Depends on:
Blocks: densifya11y
  Show dependency treegraph
 
Reported: 2012-06-06 23:50 PDT by alexander :surkov
Modified: 2012-06-08 13:57 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (111.18 KB, patch)
2012-06-07 16:16 PDT, Mark Capella [:capella]
surkov.alexander: review+
Details | Diff | Splinter Review
Patch (v2) (111.61 KB, patch)
2012-06-07 23:33 PDT, Mark Capella [:capella]
no flags Details | Diff | Splinter Review

Description alexander :surkov 2012-06-06 23:50:20 PDT

    
Comment 1 Mark Capella [:capella] 2012-06-07 16:16:55 PDT
Created attachment 631202 [details] [diff] [review]
Patch (v1)
Comment 2 alexander :surkov 2012-06-07 18:49:15 PDT
Comment on attachment 631202 [details] [diff] [review]
Patch (v1)

Review of attachment 631202 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thank you!

::: accessible/src/base/nsAccUtils.h
@@ +26,5 @@
>  class HyperTextAccessible;
>  class DocAccessible;
>  struct nsRoleMapEntry;
>  #ifdef MOZ_XUL
> +class XULTreeAccessible;

shouldn't it be namespaced?

::: accessible/src/generic/RootAccessible.cpp
@@ +54,3 @@
>  #include "nsIXULDocument.h"
>  #include "nsIXULWindow.h"
> +#include "XULTreeAccessible.h"

nit: you'd need to keep it with other accessible class files

::: accessible/src/msaa/Makefile.in
@@ +42,5 @@
>    ia2AccessibleHypertext.cpp \
>    ia2AccessibleRelation.cpp \
>    RootAccessibleWrap.cpp \
>    TextLeafAccessibleWrap.cpp \
> +  XULTreeGridAccessibleWrap.cpp \

shouldn't it be ifdefed by MOZ_XUL? (see src/Makefile.in)

::: accessible/src/msaa/nsXULTreeGridAccessibleWrap.cpp
@@ +34,5 @@
> +                                DocAccessible* aDoc,
> +                                XULTreeGridRowAccessible* aRowAcc,
> +                                nsITreeBoxObject* aTree,
> +                                nsITreeView* aTreeView,
> +                                 PRInt32 aRow, nsITreeColumn* aColumn) :

wrong indent

::: accessible/src/xul/nsXULTreeAccessible.cpp
@@ +1073,5 @@
>  }
>  
>  void
> +XULTreeItemAccessibleBase::GetCellName(nsITreeColumn* aColumn,
> +                                       nsAString& aName)

on the same line please

@@ +1181,4 @@
>  
>  void
> +XULTreeItemAccessible::RowInvalidated(PRInt32 aStartColIdx,
> +                                      PRInt32 aEndColIdx)

on the same line please

::: accessible/src/xul/nsXULTreeGridAccessible.cpp
@@ +398,5 @@
>  }
>  
>  NS_IMETHODIMP
> +XULTreeGridAccessible::IsColumnSelected(PRInt32 aColumnIndex,
> +                                          bool* aIsSelected)

on same line please
Comment 3 Mark Capella [:capella] 2012-06-07 19:10:12 PDT
FYI ReL:

::: accessible/src/base/nsAccUtils.h
@@ +26,5 @@
>  class HyperTextAccessible;
>  class DocAccessible;
>  struct nsRoleMapEntry;
>  #ifdef MOZ_XUL
> +class XULTreeAccessible;

I forgot (again) to HG Refresh the Queue before posting ... the last thing I had to do to get the build working was remove the whole #ifdef / class XULTreefoo / #endif set of lines ... It caused an ambiguous reference error in nsaccessibilityservice.cpp ...
Comment 4 Mark Capella [:capella] 2012-06-07 23:33:30 PDT
Created attachment 631286 [details] [diff] [review]
Patch (v2)

Here's the patch with comments 2 / 3 addressed ... let me know if the makefile.in tweak looks ok?
Comment 5 alexander :surkov 2012-06-07 23:34:50 PDT
yes, thank you
Comment 6 Mark Capella [:capella] 2012-06-08 01:51:06 PDT
Inbound TRY puss ...
https://tbpl.mozilla.org/?tree=Try&rev=783d249232b3
Comment 7 Mark Capella [:capella] 2012-06-08 04:11:12 PDT
inbound push
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8d547fb468e7
Comment 8 Ed Morley [:emorley] 2012-06-08 13:57:51 PDT
https://hg.mozilla.org/mozilla-central/rev/8d547fb468e7

Note You need to log in before you can comment on or make changes to this bug.