Merge abCardViewOverlay.xul into addressbook.xul

RESOLVED FIXED in seamonkey2.13

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Tracking

Trunk
seamonkey2.13
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Posted patch Do the merge (obsolete) — Splinter Review
At the moment abCardViewOverlay.xul overlays addressbook.xul but isn't used anywhere else.
This patch:
* Merges abCardViewOverlay.xul into addressbook.xul
* Merges abCardViewOverlay.dtd into abMainWindow.dtd
* Removes relevant jar.mn entries
* Removes abCardViewOverlay.xul/dtd files
Attachment #630997 - Flags: review?(mnyromyr)
Blocks: 762669
Posted patch Fix missing namespace (obsolete) — Splinter Review
Missed setting xmlns:html
Attachment #630997 - Attachment is obsolete: true
Attachment #630997 - Flags: review?(mnyromyr)
Attachment #631132 - Flags: review?(mnyromyr)
Fixed extra /
Attachment #631132 - Attachment is obsolete: true
Attachment #631132 - Flags: review?(mnyromyr)
Attachment #631178 - Flags: review?(mnyromyr)
Comment on attachment 631178 [details] [diff] [review]
Fix missing namespace and extra slash [Checked in: Comment 4]

>+<!ENTITY mapIt.tooltip                                  "Display a map of this address from the Web">

Wow, I never noticed this feature, and it's in the code since 2001. *_*

> <script type="application/javascript" src="chrome://messenger/content/addressbook/abCommon.js"/>
> <script type="application/javascript" src="chrome://communicator/content/contentAreaClick.js"/>
> <script type="application/javascript" src="chrome://global/content/printUtils.js"/>
> <script type="application/javascript" src="chrome://messenger/content/msgPrintEngine.js"/>
>+<script type="application/javascript"
>+        src="chrome://messenger/content/addressbook/abCardViewOverlay.js"/>

Please don't wrap this.

>+        <vbox id="CardViewBox"

I gather the content of this is more or less a verbatim copy of the deleted file — I didn't check every detail and I saw no errors. ;-)

>+                  <description class="CardViewHeading"
>+                               id="cvhOther">&other.heading;</description>>+                  <description class="CardViewHeading"
>+                               id="cvhDescription">&description.heading;</description>>+                  <description class="CardViewHeading"
>+                               id="cvhAddresses">&addresses.heading;</description>>+                  <description class="CardViewHeading"
>+                               id="cvhPhone">&phone.heading;</description>>+                  <description class="CardViewHeading"
>+                               id="cvhWork">&work.heading;</description>

These are quite some odd wrappings. I'd rather leave them unwrapped.

r/moa=me with that.
Attachment #631178 - Flags: superreview+
Attachment #631178 - Flags: review?(mnyromyr)
Attachment #631178 - Flags: review+
Comment on attachment 631178 [details] [diff] [review]
Fix missing namespace and extra slash [Checked in: Comment 4]

Checked in with suggested fixes:
http://hg.mozilla.org/comm-central/rev/cf074c127ab9
Attachment #631178 - Attachment description: Fix missing namespace and extra slash → Fix missing namespace and extra slash [Checked in: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.13
You need to log in before you can comment on or make changes to this bug.