762669 - Port |Bug 519961 - Get rid of XUL box for hbox element contained an inline img child warning| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Ian Neal]

Attachment: Use description port

Every time when opening the address book there are two warnings in the error console:

Warning: XUL box for hbox element contained an inline img child, forcing all its children to be wrapped in a block.
Source File: chrome://messenger/content/addressbook/addressbook.xul
Line: 0

Comment 1

[Ian Neal]

Attachment: Unbitrot myself

Managed to bitrot myself

Comment 2

[[e-mail]]

Comment on attachment 631180 [details] [diff] [review]
Unbitrot myself

So, it turns out that XUL image resizing was fixed by bug 585069, so we can throw out all of these HTML hacks and just use an <image>. (You can probably ditch the <hbox> and <spacer>s too by putting align="center" on the <vbox>.)

Comment 3

[Philip Chee]

Hey! I thought I already fixed it here:
http://hg.mozilla.org/comm-central/rev/83dfe09bf8ff#l2.31
https://bugzilla.mozilla.org/show_bug.cgi?id=116114#c8

Comment 4

[Ian Neal]

Attachment: Using <image> [Checked in: Comment 6]

Using <image> rather than <html:img>

Comment 5

[[e-mail]]

Comment on attachment 631551 [details] [diff] [review]
Using <image> [Checked in: Comment 6]

>+              <vbox id="cvbPhoto" class="cardViewGroup" align="center">
I think we need to fix the width of this box (previously defined on the hbox that was removed). r=me with that fixed.

Comment 6

[Ian Neal]

Comment on attachment 631551 [details] [diff] [review]
Using <image> [Checked in: Comment 6]

Checked in with suggested fix:
http://hg.mozilla.org/comm-central/rev/47a3e0556156