Closed
Bug 762669
Opened 12 years ago
Closed 12 years ago
Port |Bug 519961 - Get rid of XUL box for hbox element contained an inline img child warning| to SeaMonkey
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, defect)
SeaMonkey
MailNews: Address Book & Contacts
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.13
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file, 2 obsolete files)
1.56 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
Every time when opening the address book there are two warnings in the error console: Warning: XUL box for hbox element contained an inline img child, forcing all its children to be wrapped in a block. Source File: chrome://messenger/content/addressbook/addressbook.xul Line: 0
Attachment #631128 -
Flags: review?(neil)
Managed to bitrot myself
Attachment #631128 -
Attachment is obsolete: true
Attachment #631128 -
Flags: review?(neil)
Attachment #631180 -
Flags: review?(neil)
Comment 2•12 years ago
|
||
Comment on attachment 631180 [details] [diff] [review] Unbitrot myself So, it turns out that XUL image resizing was fixed by bug 585069, so we can throw out all of these HTML hacks and just use an <image>. (You can probably ditch the <hbox> and <spacer>s too by putting align="center" on the <vbox>.)
Attachment #631180 -
Flags: review?(neil) → review-
Comment 3•12 years ago
|
||
Hey! I thought I already fixed it here: http://hg.mozilla.org/comm-central/rev/83dfe09bf8ff#l2.31 https://bugzilla.mozilla.org/show_bug.cgi?id=116114#c8
Using <image> rather than <html:img>
Attachment #631180 -
Attachment is obsolete: true
Attachment #631551 -
Flags: review?(neil)
Comment 5•12 years ago
|
||
Comment on attachment 631551 [details] [diff] [review] Using <image> [Checked in: Comment 6] >+ <vbox id="cvbPhoto" class="cardViewGroup" align="center"> I think we need to fix the width of this box (previously defined on the hbox that was removed). r=me with that fixed.
Attachment #631551 -
Flags: review?(neil) → review+
Comment on attachment 631551 [details] [diff] [review] Using <image> [Checked in: Comment 6] Checked in with suggested fix: http://hg.mozilla.org/comm-central/rev/47a3e0556156
Attachment #631551 -
Attachment description: Using <image> → Using <image> [Checked in: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.13
You need to log in
before you can comment on or make changes to this bug.
Description
•