762594 - Prompts to save unmodified message forward draft

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Jonathan Kamens]

If I click the Forward button on a message, and then immediately try to close the window, TB asks me if I want to save it.

I'm fairly certain this is new behavior. If I haven't modified the draft after clicking the Forward button, then it shouldn't be prompting me, and I don't think it has in the past.

I'm marking this as a regression. Feel free to remove the keyword if I'm wrong about the previous behavior, but I don't think I am.

Comment 1

[rsx11m]

TB Daily 13.0a1 build from March 3 doesn't ask on close.
TB 13.0 beta 1 (April 25) *does* ask to save as draft.

Also applies to Linux x86_64, composing in HTML mode.

Comment 2

[Magnus Melin [:mkmelin]]

Regression window http://hg.mozilla.org/comm-central/pushloghtml?startdate=2012-03-21&enddate=2012-03-22. 

Bug 736055 looks like the most likely cause, or possibly bug 650776.

Comment 3

[Mark Banner (:standard8)]

Hmm, I'm pretty sure there's some sort of hack or work around to "reset" the editor when we start up the compose window, I'm hoping someone might be able to remember where that is.

Comment 4

[[e-mail]]

Well, the typical sequence goes like this (error checking removed for sanity)

m_editor->EnableUndo(false);
/* do stuff here */
m_editor->EnableUndo(true);
SetBodyModified(false);

SetBodyModified(false) is a wrapper around m_editor->ResetModificationCount();

Comment 5

[Magnus Melin [:mkmelin]]

I've got a fix for this, just need to improve the tests for it.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

Sorry, forgot a qrefresh... this is the final version

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 684935 [details] [diff] [review]
proposed fix, v2

Review of attachment 684935 [details] [diff] [review]:
-----------------------------------------------------------------

I'm good with this. Thanks Magnus!

Comment 9

[Magnus Melin [:mkmelin]]

http://hg.mozilla.org/comm-central/rev/65f054d50891 -> FIXED

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 684935 [details] [diff] [review]
proposed fix, v2

Review of attachment 684935 [details] [diff] [review]:
-----------------------------------------------------------------

Do we want this for esr?

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 684935 [details] [diff] [review]
proposed fix, v2

[Triage Comment]
Yes, I think we should take it for ESR. We'll also land on aurora ready for the next beta.

Comment 12

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/988edf8b927b

Comment 13

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr17/rev/3546a1cdce58