Last Comment Bug 762704 - Add layout sub menu to view menu in addressbook
: Add layout sub menu to view menu in addressbook
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: MailNews: Address Book & Contacts (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: seamonkey2.13
Assigned To: Ian Neal
:
:
Mentors:
Depends on:
Blocks: 763284
  Show dependency treegraph
 
Reported: 2012-06-07 15:43 PDT by Ian Neal
Modified: 2012-07-04 03:42 PDT (History)
1 user (show)
iann_bugzilla: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Add layout submenu [Checked in: Comment 2] (8.49 KB, patch)
2012-06-07 15:43 PDT, Ian Neal
mnyromyr: review+
Details | Diff | Splinter Review

Description Ian Neal 2012-06-07 15:43:14 PDT
Created attachment 631185 [details] [diff] [review]
Add layout submenu [Checked in: Comment 2]

This ports part of TB Bug 609245 and removes the Card Summary Pane option from the Show/Hide submenu and adds a new layout submenu (similar to the mail window) that has options for both Contact Pane and Directory Pane.
Potentially could have:
* F8 and F9 as shortcut keys (as they are for the mail window).
* the splitter being hidden when using anything but clicking on the splitter.
* more code making use of the new helper.
Comment 1 Karsten Düsterloh 2012-07-03 15:26:55 PDT
Comment on attachment 631185 [details] [diff] [review]
Add layout submenu [Checked in: Comment 2]

>+<!ENTITY showContactPane2.label                         "Contact Pane">

That 2 is even odd for the broken entity renaming scheme l10n folks are forcing upon us - there never even was a similarily named something before in our code!
(You can ignore this rant. *g*)

>+function InitViewLayoutMenuPopup(aEvent) {

Please wrap that brace onto the next line.
Comment 2 Ian Neal 2012-07-04 03:41:57 PDT
Comment on attachment 631185 [details] [diff] [review]
Add layout submenu [Checked in: Comment 2]

Checked in with change as suggested.
http://hg.mozilla.org/comm-central/rev/2d4c1cd4193f

Note You need to log in before you can comment on or make changes to this bug.