762854 - No email send after invitation creation [Exception 'TypeError: aItem.calendar.canNotify is not a function' in calProviderUtils.jsm]

Status: RESOLVED FIXED

(Calendar :: Provider: Local Storage, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning 1.8a1 (custom build) with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Thunderbird/16.0a1 (BuildID: 20120607030200)

Steps to reproduce:
1. create a new Thunderbird profile
2. install Lightning extension
3. create event in the default Home calendar and invite attendees

Result:
No event invitation is send. Error console shows:

Error: 'TypeError: aItem.calendar.canNotify is not a function' when calling method: [calIOperationListener::onOperationComplete] = NS_ERROR_XPC_JS_THREW_JS_OBJECT
Source file: resource://calendar/modules/calProviderUtils.jsm
Line: 650

Lightning 1.5 works. After creating the event the Outlook compatibility dialog is shown and afterwards the email is send. Maybe Lightning 1.6 or Lightning 1.7 are affected too but I cannot specify regression range due to the lack of nightly builds. Maybe related to Bug 751923.

Comment 1

[Stefan Sitter [:ssitter]]

Lightning 1.7 shows the same problem.

Comment 2

[Stefan Sitter [:ssitter]]

I think the problem is that canNotify() is declared in calISchedulingSupport but this interface is not implemented by calStorageCalendar. What would be the correct fix? Implement calISchedulingSupport in calStorageCalendar?

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Isn't it implemented by calProviderBase?

Comment 4

[Stefan Sitter [:ssitter]]

Attachment: add calISchedulingSupport to getInterfaces()

I see now. Seems that we need to announce the interfaces too we get via __proto__ from cal.ProviderBase.prototype.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 633920 [details] [diff] [review]
add calISchedulingSupport to getInterfaces()

Review of attachment 633920 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp

Comment 6

[Stefan Sitter [:ssitter]]

pushed to https://hg.mozilla.org/comm-central/rev/38c8671e8bc1

Comment 7

[Stefan Sitter [:ssitter]]

pushed to https://hg.mozilla.org/releases/comm-aurora/rev/5c55719c34fd

Comment 9

[Julián Amer]

I upgraded to thunderbird 15.0 and Lightning 1.7 a few days ago.

Now I tried to create an event in local calendar and invite a partner, isn't send email and isn't error on the console.

When I deleted the event, then an e-mail notification  is sended.

I repeated the process, but this time I used a google calendar synchronized through CALDAV.

I created the event, and invited a partner, isn't send the email and error appear in the console saying:

Fecha y hora: 31/08/2012 10:36:37
Error: [Exception... "'TypeError: aItem.calendar.canNotify is not a function' when calling method: [calIOperationListener::onOperationComplete]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "JS frame :: resource://calendar/modules/calProviderUtils.jsm :: cPB_notifyOperationComplete :: line 650"  data: no]
Archivo de origen: resource://calendar/modules/calProviderUtils.jsm
Línea: 650

I verify the file of the url https://hg.mozilla.org/releases/comm-aurora/rev/5c55719c34fd with my local copy of the calStorageCalendar.js and has been corrected, but the error isn't resolved.

Please can help me?

Comment 10

[Stefan Sitter [:ssitter]]

Julián, this was a problem with storage provider and has been fixed. But according to your description you are using caldav provider and not storage provider. Please check if there is already a bug report for caldav provider and file an new bug report if not.