IonMonkey: Fix ss-fannkuch phi specialization

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Another ss-fannkuch problem. There's a bunch of LValueToInt32 instructions caused by suboptimal phi specialization in some edge cases.
(Assignee)

Comment 1

5 years ago
Created attachment 631391 [details] [diff] [review]
Patch

GuessPhiType tries to guess the type of the phi based on the operand types. If all operands are phis we still have to visit, GuessPhiType returns MIRType_None.

The patch ensures we never propagate MIRType_None to other phis. We have to wait until we know one of the operand types and then we can propagate the type.

This + bug 762887 should make ss-fannkuch a bit faster, but especially x86 needs more work.
Attachment #631391 - Flags: review?(dvander)
Attachment #631391 - Flags: review?(dvander) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/beabf74b228d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.