Closed Bug 762891 Opened 11 years ago Closed 10 years ago

IonMonkey: Fix ss-fannkuch phi specialization

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Another ss-fannkuch problem. There's a bunch of LValueToInt32 instructions caused by suboptimal phi specialization in some edge cases.
Attached patch PatchSplinter Review
GuessPhiType tries to guess the type of the phi based on the operand types. If all operands are phis we still have to visit, GuessPhiType returns MIRType_None.

The patch ensures we never propagate MIRType_None to other phis. We have to wait until we know one of the operand types and then we can propagate the type.

This + bug 762887 should make ss-fannkuch a bit faster, but especially x86 needs more work.
Attachment #631391 - Flags: review?(dvander)
Attachment #631391 - Flags: review?(dvander) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/beabf74b228d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.