76315 - Innapropriate "Don't show this dialog again" checkbox from bookmarks manager.

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Paul McGarry]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.2 i686; en-US; rv:0.8.1+) Gecko/20010415
BuildID:    2001041505

When adding a bookmark from the bookmark manager the "Add bookmark" dialogue has
a "Don't show this dialog again" option. This option isn't valid here as when
adding a bookmark via this route you _need_ to show this dialog in order to set
the URL and Name for the bookmark.

The problem stems from the fact that the dialogue is shared with the "Add
bookmark" functions elsewhere, where the URL and name are already set (to the
current page) and the dialogs sole purpose is to allow the user to choose a
folder to stick it in.

Reproducible: Always
Steps to Reproduce:
1.Fire up Mozilla
2.Click on Bookmarks->Manage Bookmarks
3.In the resulting Bookmark manager, click File->New Bookmark.


Actual Results:  See the checkbox, and wonder what would happen in future if you
checked it.

Expected Results:  The checkbox should not be there confusing the user.

Comment 1

[Nick Rosier]

Confirmed with build 2001041704 on W2K 

Comment 2

[Matthew T (active 1999-2002)]

Well spotted. However, I think this is about to go away with the fix for bug 
68654.

Comment 3

[Claudius Gayle]

setting confirmed bit. mpt is exactly right so we'll just wait and watch. If that is fixed and verified
then this is 'fixed'.

I should note for the curious if you do check that box two things hanppen.

1. you still get the dialog (of course) but the box is unchecked again.

2. Worse, the pref is set and now you won't get the dialog when selecting 'Add current Page'
which is actually really bad b/c you won't know what the heck you did and how do you undo it?

Comment 4

[Blake Ross]

Fixed.

Comment 5

[Claudius Gayle]

VERIFIED Fixed with 2001042604 build