68654 - Reinstate dialog-less method of adding bookmark (no pref)

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Ben Bucksch (:BenB)]

------- Additional Comments From Ben Bucksch 2001-02-11 02:11 -------

I see an item "Always ask me to choose a title and folder when adding a new
bookmark". I think, this is a bad idea. This is not a preference, it depends on
the situation. Usually, I want to specify a folder, but sometimes, I have no time.
Also, the pref has no effect. Who checked that in and why???

------- Additional Comments From [e-mail] 2001-02-11 10:32 -------
Let's wait for bug 67884 to be addressed. I think the current default behaviour
 ("Always ask" enabled) is correct, an option to de-activate it is trivial but
not completely useless. The proposed alternative, i.e. a second option for
saving a bookmark in the Bookmarks menu (besides the "Add current page") would
be a really bad idea.

------- Additional Comments From Ben Bucksch 2001-02-12 12:50 -------
I need to press a button to be able to choose a folder. That's a no-option,
since this is the reason why I (and lots of others, I assume) need the dialog at
all. One extra click each time is too much.

------- Additional Comments From [e-mail] 2001-02-12 13:32 -------
Ben, sorry for repeating myself here but where is the need to have one 
more choice in the Bookmarks menu (add without dialog box) while in most cases 
we have to modify the title? I think this will clutter the menu with a rarely 
useful option. Current implementation is already a big step ahead of what old 
Navigator was. Why to complicate it? Imho, at the moment of creation, an average 
user modifies the title only, later he massively categorises the new bookmarks 
folders (if he ever does this). 


------- Additional Comments From Ben Bucksch 2001-02-12 20:19 -------

> in most cases we have to modify the title?

I rarely edit titles. I usually want to specify another *folder*.

> I think this will clutter the menu with a rarely useful option.

I completely disagree. 4.x had both options (file instantly, file in folder), too.

I need a way to instantly, quickly bookmark a page. Sometimes, I have lots of
windows open and suddenly have to close the browser for any reason (e.g.
instability or shutting down the OS). No time to hit a menu item *plus* OK (for
the dialog) for each windown (there migh be dozens).

This was just one example. I'm sure other people have other reasons why they
sometimes what to add a bookmark instantly.

I assume that almost everybody sometimes wants to edit a bookmark
(title/URL/folder) while adding it. So IMO, the pref is pointless, because I
cannot see any significant amount of people having this "preference".

> [...] an average user[...]

I disagree with that assertion, but it currently doesn't matter.


---

This is a major regression.

Comment 1

[Matthew T (active 1999-2002)]

Bookmarks menu
--------------
  A_dd Bookmark                Ctrl+D 
  Add Bookmark _As ...   Shift+Ctrl+D
-------------------------------------
  Manage _Bookmarks ...        Ctrl+B
-------------------------------------
  {bookmarks}

Comment 2

[timeless]

Add Bookmark As Pig, As Wurm, as ?? I think that you are trampling the English 
language.
perhaps
Add Bookmark|
Bookmark Page             ctrl-d
Create Bookmark ... shift-ctrl-d

Comment 3

[Ben Bucksch (:BenB)]

> I think that you are trampling the English language.

No, he just uses the "Save As..." pattern.

Comment 4

[timeless]

my roommate thinks that "add bookmark as ..." would imply he could put the 
bookmark on the desktop or in some other place outside of bookmarks.

If anyone improves our dialog to support that then the wording is acceptable, 
until then add bookmark as is unacceptable.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

The pref is good enough. 

Comment 6

[Ben Bucksch (:BenB)]

No, it isn't. As I said, there are valid reasons for the same user to want both
dialogs. REOPENing. If you don't want to fix it, reassign it, but don't mark it
WONTFIX, i.e. "should not be fixed".

Comment 7

[Ben Bucksch (:BenB)]

s/dialogs/options/

Comment 8

[Claudius Gayle]

Sometimes I feel like a nut, sometimes I don't. Seriously, I would love to go with mpt's
2-13 comments. We should have the instant method and the 'Add Bookmark In...' method.
Then naturally, we wouldn't need the pref.
Speaking as Joe User ( I really am Joe User) I would hurriedly check that checkbox b/c i in
general hate nagging dialogs asking me to do more work, and then one day be pissed when
I wanted it and didn't know how to get it back (how do you btw?).

Some things we actually did pretty close to correctly in NS4.x, after all the clamor to get
this much loved feature in, let's not muck it up.

The same user wants to add bookmarks in place (sometimes), she also wants to just add them
with a single click, and she wants the choice of when to do so.

Do _not_ future this btw. If you still disagree bump it over to UIDF and we'll see what german
and mpt say (wanna guess?)

Comment 9

[Ben Bucksch (:BenB)]

Sorry for quoting too much in the intial description. (I just reread the bug.)

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

OK I guess mpt's solution could work. Let's try it out and see what happens...

Clearing keyword field as I've targeted for .9 and this is neither a regression 
nor a 4xp bug. 

Comment 11

[Ben Bucksch (:BenB)]

Keywords:
I agree that this is not a regression, since I can get the old behaviour
(although it is pointless, because I can't use the new functionality then).
But it is clearly 4xp: 4.x offered both (at the same time) the ability to file a
bug in a folder and to add it instantly.
Also, nominations must persist. What, if you change your mind tomorrow and
reassign or move to Future?

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Refer to bugs on drag ("quick") filing of bookmarks for the 4xp mechanism 
(these bugs are on my list). The implementation suggestion is NOT 4xp. 

Comment 13

[Paul Chen]

Marking nsbeta1+, p3

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch to implement mpt's proposal.

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: remove pref for bookmark dialog, checkbox from bookmark dialog for pref, and redunant pref UI

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

fixed. 

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

booya

Comment 18

[Claudius Gayle]

whoop there it is - on all platforms with 2001042608 builds