763200 - java.lang.NullPointerException: at org.mozilla.gecko.GeckoApp$FilePickerResultHandler.handleActivityResult(GeckoApp.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

There is a crash in 14.0b6 on this line:
http://hg.mozilla.org/releases/mozilla-beta/file/7054a9e24f11/mobile/android/base/GeckoApp.java#l2726

Crash report at bp-5200426d-13e8-4297-9e19-42b8c2120609.

This bug was spawned off https://bugzilla.mozilla.org/show_bug.cgi?id=758854#c11

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c11efe87662

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9c11efe87662

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 631668 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 741284
User impact if declined: Potentially a crash when using a filepicker and not picking a file. The crash might only happen when using a 3rd-party file picker.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): mobile-only, low risk
String or UUID changes made by this patch: none

Nom'ing for both aurora and beta since it's a really safe patch. However, it's a rare crash, so might only be worth uplifting to aurora.

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 631668 [details] [diff] [review]
Patch

[Triage Comment]
Since this is a rare crash, let's only land on Aurora.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/440a35cc1ebc