763341 - Chrome QI of content object fails for new bindings

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

A common thing that happens in our test suite is:

enablePrivilege('UniversalXPConnect');
someDOMObject.QueryInterface(Ci.foo).doSomething;

The easiest way to fix this is to use SpecialPowers.wrap(someDOMObject). But this fails for new bindings, because our QueryInterface implementation doesn't unwrap.

As long as we're going to support this pseudo-QI implementation for the new bindings, we should make sure it works from chrome too. Patch coming up.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Handle wrappers in new dom binding QI. v1

The |ok| parent check goes away because it's ill-conceived. All it's really checking is that proxies are parented to the global, and it's impossible to port to SpecialPowers, because SpecialPowers will think that the proxy is parented to the SpecialPowers global. I don't think this check is very important, so I removed it.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 631766 [details] [diff] [review]
Handle wrappers in new dom binding QI. v1

Review of attachment 631766 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/tests/chrome/test_wrappers.xul
@@ +70,5 @@
> +
> +   // Test QI on new dom bindings.
> +   var contentXHR = XPCNativeWrapper(win.wrappedJSObject.xhr);
> +   try {
> +     QIed = contentXHR.QueryInterface(Components.interfaces.nsIClassInfo);

var QIed?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 631766 [details] [diff] [review]
Handle wrappers in new dom binding QI. v1

r=me

Comment 4

[Bobby Holley (:bholley)]

Pushed to try, along with another patch: https://tbpl.mozilla.org/?tree=Try&rev=29d25bdd5cc2

Comment 5

[Bobby Holley (:bholley)]

Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/b4dbb556a619

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/b4dbb556a619