818281 - Remove DOMClassInfo remnants from XMLHttpRequest

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

prefable: True has been removed by bug 814821.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 2

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=4c3066547131
Hm, this patch caused the following regressions.

Bug 763341:
new XMLHttpRequest().QueryInterface(Components.interfaces.nsIClassInfo) fails
(but new XMLHttpRequest().QueryInterface(Components.interfaces.nsIXMLHttpRequest) succeeds)

Bug 317448, Bug 435425:
new XMLHttpRequest() instanceof Components.interfaces.nsIXMLHttpRequest fails
(but new XMLHttpRequest() instanceof XMLHttpRequest succeeds)

Is this expected?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> new XMLHttpRequest().QueryInterface(Components.interfaces.nsIClassInfo) fails

That seems fine to me.

> new XMLHttpRequest() instanceof Components.interfaces.nsIXMLHttpRequest fails

Ah.  That's because nsJSIID::HasInstance checks for classinfo....

Peter, would it make sense to just fall back to QI there if no classinfo on a new-binding object?

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Part 1: Remove legacy XHR constructor

This part should have no side effect.
https://tbpl.mozilla.org/?tree=Try&rev=9c4f69ab853b

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 688757 [details] [diff] [review]
Part 1: Remove legacy XHR constructor

r=me

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

(I don't know what info was needed from me)

I assume QIing in general doesn't fail.

Comment 7

[Masatoshi Kimura [:emk]]

Attachment: Part 2: Remove DOMClassInfo remnants from XMLHttpRequest

- test_wrappers.xul will need an update again when Screen is unpref'ed. But I think we should have a test until the last classinfo is removed from new-bindings objects.
- test_bug317448.html has been removed because it doesn't make sense in the new-bindings world.
- test_bug435425.html is now using regular constructor objects instead of SpecialPowers.Ci.nsIFoo.

Try result:
https://tbpl.mozilla.org/?tree=Try&rev=ff1cb49b1ff8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b80ceb7da72

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5b80ceb7da72

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 690087 [details] [diff] [review]
Part 2: Remove DOMClassInfo remnants from XMLHttpRequest

r=me.  Thank you!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4554dabda4cc

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4554dabda4cc