763409 - Make Hardware and OS fields optional

Status: NEW

(Bugzilla :: Administration, task, P1)

Description

[[e-mail]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1084.52 Safari/536.5

Steps to reproduce:

I tried to hide fields OS and Hardware from user interface, as we don't use them


Actual results:

I didn't find an option for that in administration


Expected results:

I expected to find option "useplatform" and "useopsys" under Parameters -> Bugfields to turn off these two fields.

Comment 2

[Frédéric Buclin]

I'm going to add a parameter for them rather than implementing them as a custom field. Reopening!

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

There is still one minor change I need to do in admin/custom_fields/edit-common.html.tmpl to exclude these two fields, but this template doesn't exist yet. :)

I will attach a follow-up patch to this bug once bug 802613 has been reviewed and checked in.

Comment 4

[Frédéric Buclin]

Attachment: patch, v1.1

Comment 5

[Frédéric Buclin]

Attachment: patch, v1.2

Unbitrotten patch

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 686802 [details] [diff] [review]
patch, v1.2

Review of attachment 686802 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 1:

Need to update config.cgi as well:

my %FIELD_PARAMS = (
    classification    => 'useclassification',
    target_milestone  => 'usetargetmilestone',
    qa_contact        => 'useqacontact',
    status_whiteboard => 'usestatuswhiteboard',
    see_also          => 'use_see_also',
    rep_platform      => 'use_os_platform',
    op_sys            => 'use_os_platform',
);
foreach my $field (@fields) {
    my $param = $FIELD_PARAMS{$field->name};
    $field->{is_active} =  Bugzilla->params->{$param} if $param;
}
$vars->{'field'} = \@fields;

Comment 2:

whine.pl and it's templates contain rep_platform as one of the returned columns so it should be omitted if use_os_platform is false.

::: Bugzilla/Config/BugFields.pm
@@ +50,5 @@
>  
>    {
> +   name => 'use_os_platform',
> +   type => 'b',
> +   default => 1

You have this default to 0 in Bugzilla/Config.pm for new installs but default to 1 here? Should it not be 0 also?

::: template/en/default/bug/edit.html.tmpl
@@ +282,1 @@
>              bug = bug, field = bug_fields.op_sys, 

nit: remove whitespace

::: template/en/default/list/edit-multiple.html.tmpl
@@ +106,5 @@
> +        <label for="rep_platform">
> +          <a href="page.cgi?id=fields.html#rep_platform">
> +            [% field_descs.rep_platform FILTER html %]</a>:
> +        </label>
> +      </th>

If you are moving these lines anyway, why not go ahead and convert to [% PROCESS bug/field-label.html.tmpl %] calls anyway? Same for op_sys.

::: template/en/default/search/form.html.tmpl
@@ +211,5 @@
> +    [% IF Param('use_os_platform') %]
> +      [% INCLUDE "search/field.html.tmpl" 
> +          field => bug_fields.rep_platform 
> +          accesskey =>"h"
> +          value => default.rep_platform

nit: line up =>

@@ +214,5 @@
> +          accesskey =>"h"
> +          value => default.rep_platform
> +      %]
> +      [% INCLUDE "search/field.html.tmpl" 
> +          field => bug_fields.op_sys 

nit: remove ending whitespace.

Comment 7

[Anish Mangal]

Attachment: Patch rebased on 4.4

Am adding this patch file which is rebased on 4.4, just in case someone wants to use it (while it passed the review queue into mainline). 

I haven't thoroughly tested it, but it seems to be working on the face of it.

Comment 8

[Drew DeVault]

Sorry to necropost, but this seems to have stagnated and I'd like to see it get mainlined. 8 years ago this was the most requested feature, today it's still annoying that it's not in.

Comment 9

[moshe.kamensky]

Attachment: use_os.diff

New patch, for v5.1

Comment 10

[[e-mail]]

I am glad this is finally heading somewhere :)

Comment 11

[u682406]

Hello, would be nice to see this finally finished after 9 years.