763433 - ExposedPropertiesOnly::check should leave the chrome compartment before checking UniversalXPConnect

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

This isn't a problem on trunk, because we don't base CAPS security decision on the context compartment. But with bug 754202, we do. Let's fix this.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Part 1 - Clarify compartment semantics for ExposedPropertiesOnly. v2

Comment 2

[Bobby Holley (:bholley)]

Attachment: Part 2 - Clarify compartment situation in Xray wrapper. v1

Adding to the mess of the NodePrincipal (et al) check isn't great, but I'm refactoring that in bug 761704.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 632212 [details] [diff] [review]
Part 1 - Clarify compartment semantics for ExposedPropertiesOnly. v2

Review of attachment 632212 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/wrappers/AccessCheck.cpp
@@ +447,5 @@
>      }
> +
> +    // Double-check that the subject principal according to CAPS is a content
> +    // principal rather than the system principal. If it is, this check is
> +    // meaningless.

If it is or if it is not?

Comment 4

[Bobby Holley (:bholley)]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=0eb257679869

Comment 5

[Bobby Holley (:bholley)]

Pushed to m-i:

http://hg.mozilla.org/integration/mozilla-inbound/rev/256b856c0da6
http://hg.mozilla.org/integration/mozilla-inbound/rev/9523d286839d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9523d286839d
https://hg.mozilla.org/mozilla-central/rev/256b856c0da6