Firefox win32 l10n builds broke since Jun 8th because Win2008R2 check not avail in NSIS 2.33

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Installer
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Alexander L. Slovesnik, Assigned: bbondy)

Tracking

unspecified
Firefox 16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Last win32 builds in http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/ are from Jun 8th. Tinderbox log ( http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1339421691.1339421808.29680.gz ) shows following errors:

!insertmacro: macro "_And" requires 4 parameter(s), passed 2!
Error in script "installer.nsi" on line 923 -- aborting creation process
make[2]: Leaving directory `/e/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/browser/installer/windows'
make[1]: Leaving directory `/e/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/browser/locales'
make[2]: *** [l10ngen/setup.exe] Error 1
make[1]: *** [repackage-win32-installer] Error 2
make: *** [repackage-win32-installer-ru] Error 2
program finished with exit code 2

Perhaps it's caused by Bug 760671

Comment 1

5 years ago
Robert, any idea?
Let's add bbondy since he wrote the patch for Bug 760671
(Assignee)

Comment 3

5 years ago
Is a different version of NSIS used? It sounds like AtMostWin2008R2 is not defined.
I bet it is using 2.33 which doesn't have 2008 defined. I bet it will need something similar to bug 668574 to add the capability to deal with 2008, etc.
(Assignee)

Comment 5

5 years ago
Yup if it's using 2.33, I just verified and as Robert said, the latest it has is Vista.  I'll try to get a patch together today to fix this.
FYI, RelEng is going to be installing NSIS 2.46u because Thunderbird needs it, so it might be possible to switch mozilla-central over to that. Bug 762218 tracks getting it on all the slaves.
(Assignee)

Comment 7

5 years ago
Is this happening really soon? if not I'll still write a patch for this.
Hmm, missed that it is unassigned so you should probably go ahead with a workaround in the meantime.
(Assignee)

Updated

5 years ago
Assignee: nobody → netzen
(Assignee)

Updated

5 years ago
Assignee: netzen → nobody
Summary: No Firefox win32 l10n builds for mozilla-central since Jun 8th → Firefox win32 l10n builds broke since Jun 8th because Win2008R2 check not avail in NSIS 2.33
(Assignee)

Comment 9

5 years ago
Created attachment 632012 [details] [diff] [review]
Patch v1

Tested by making a local nsi file and including override.nsh with the change inside this patch.
Assignee: nobody → netzen
Attachment #632012 - Flags: review?(robert.bugzilla)
(Assignee)

Comment 10

5 years ago
I tried this on win7, win2008r2, and win8 and the check works correctly on all.
(Assignee)

Comment 11

5 years ago
Comment on attachment 632012 [details] [diff] [review]
Patch v1

Hey Jim, would you be able to pickup this review? I don't want to keep l10n builds broken for too long and rstrong is flooded with some critical reviews for app update and about 7 other patches I asked for review on for telemetry data.
Attachment #632012 - Flags: review?(robert.bugzilla) → review?(jmathies)
(Assignee)

Comment 12

5 years ago
try builds work with this patch also:
https://tbpl.mozilla.org/?tree=Try&rev=aad2c0eb66ed

Updated

5 years ago
Attachment #632012 - Flags: review?(jmathies) → review+
(Assignee)

Comment 13

5 years ago
Verified this locally by replacing my makensis 2.46 with 2.33 and doing an l10n -fr build.  Could reproduce before the patch and can't after the patch.
(Assignee)

Comment 14

5 years ago
http://hg.mozilla.org/mozilla-central/rev/798d248adc84
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Component: Release Engineering → Installer
Product: mozilla.org → Firefox
QA Contact: release → installer
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Version: other → unspecified
Comment on attachment 632012 [details] [diff] [review]
Patch v1

Looks good!
Attachment #632012 - Flags: review+
You need to log in before you can comment on or make changes to this bug.