762218 - get nsis 2.46 consistently deployed to all win32, win64 slaves

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[[e-mail] (:bhearsum)]

We upgraded a few slaves to a new NSIS in bug 761255, they're currently locked to a single master so they don't break Firefox builds. We need to find some way to get the slaves consistent again, and return mw32-ix-slave02, 05, and 10 to the main pool.

Comment 1

[Chris AtLee [:catlee]]

also needed on win64 slaves since we'll be doing release builds on them in a shortish timeframe

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

per postmortem mtg:

0) This bug remains critical because of complexities it causes us for TB releases on FF production machines.

1) We'll *not* block waiting for new version of MozillaBuild. Safer to just take this NSIS change only.

2) Soon will be doing release builds on win64, so will need to do a staging release before then. Would be good to have new NSIS deployed before then.

Pushing to jhopkins to own figuring this out and make this happen.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbot-configs] wip PATH change

This was enough to get
 PATH=D:\mozilla-build\nsis-2.46u;D:\mozilla-build\msys\local\bin;...
and 
 checking for makensisu-2.46... /d/mozilla-build/nsis-2.46u/makensisu-2.46
 checking for Unicode NSIS with major version == 2 and minor version >= 33... yes
in the compile step of a 'TB WINNT 5.2 comm-central build' job; log at [1].
That's using mw32-ix-slave01, a staging slave with 2.46u installed but no change to d:\mozilla-build\msys\etc\profile.d\profile-extrapaths.sh. We definitely need to clobber hard otherwise configure caches the 2.33 it found previously.

The build is still running and will need testing, but my dumps of the master indicate PATH will be modified in 'make installer' step too so it should work OK. The en-US release build uses the same factory, so it gets the change for free. The Release repacks set the env on every step, so they're OK. I think we'll need a change for nightly repacks though, env=self.env isn't currently set on the configure step.

[1] http://dev-master01.build.scl1.mozilla.com:8710/builders/TB%20WINNT%205.2%20comm-central%20build/builds/2/steps/compile/logs/stdio

Comment 4

[John Hopkins (:jhopkins)]

I'm ready to install NSIS 2.46u to all win32/win64 build machines.  Just waiting for FF/TB 13.0.1 to be released.

Comment 5

[John Hopkins (:jhopkins)]

NSIS 2.46u is now installed to all the win32 build machines in d:\mozilla-build\nsis-2.46u

The win64 build machines already have NSIS 2.46u installed on them in c:\mozilla-build\nsis-2.46u

Comment 6

[John Hopkins (:jhopkins)]

profile-extrapaths.sh changes reverted on mw32-ix-slave02, mw32-ix-slave05, mw32-ix-slave10.  We will control which nsis is in use via buildbot-configs PATH setting.

Comment 7

[John Hopkins (:jhopkins)]

For completeness, the 3 machines mentioned in comment 6 were the original 3 that I had manually configured.  i've undone the manual path change in profile-extrapaths.sh (that is what the bug is referring to), so those 3 are now exactly the same as all the others.  Each one has been rebooted to reset its PATH.

Comment 8

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(Reopened by accident. gggrrrrrr.... I really do not like that bugzilla-cache-bug. )

Comment 9

[Armen [:armenzg]]

Win32-ix-ref got missed (bug 802185) and reference documentation.
Are the instructions on bug 802185 correct to fix the ref machine?
Where can the binary be found?

Comment 10

[John Hopkins (:jhopkins)]

(In reply to Armen Zambrano G. [:armenzg] from comment #9)
> Win32-ix-ref got missed (bug 802185) and reference documentation.
> Are the instructions on bug 802185 correct to fix the ref machine?

Yes, those are the correct instructions, assuming that mozilla-build is on the D: drive.

> Where can the binary be found?

Use this binary: https://hg.mozilla.org/mozilla-build/file/ae3600fddd4b/nsis-2.46-Unicode-setup.exe

(it is originally from http://code.google.com/p/unsis/downloads/detail?name=nsis-2.46-Unicode-setup.exe)