Closed Bug 76359 Opened 24 years ago Closed 23 years ago

Plaintext quote styles ignored

Categories

(SeaMonkey :: Themes, defect)

Product:
SeaMonkey
Component:
Themes
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.4

People

(Reporter: BenB, Assigned: BenB)

References

Details

(Keywords: modern, regression)

Attachments

(1 file)

Fix, version 1. Comment out offending lines. Also contains source reformatting.
5.47 KB, patch
Details | Diff | Splinter Review 
In Mozilla 0.8.1, the styles for quotes in plaintext msgs are ignored. The quote
border are blue instead of black and have a too large hmargin.

I thought, it were related to the new thread pane, but that hasn't landed before
0.8.1. Might be caused by checkin version 14. of mailheader.css from hewitt;
checking atm...
s/black/grey/

I reverted some of the above mentioned checkin, but I see no improvement.


The following rules are ignored:
.moz-txt-sig > a,
.moz-signature > a {
  color: #7777FF /* light blue */;
}
.moz-text-flowed blockquote {
  margin: inherit;
  border-width: medium;
  border-color: gray;
}
.moz-text-plain[graphical-quote="true"] blockquote {
  margin: inherit;
  border-width: medium;
  border-color: gray;
}

The following rules work:
.moz-text-plain[graphical-quote="true"] .moz-txt-citetags {
  display: none;
}
.moz-text-plain pre {
  font-family: inherit;
}
.moz-txt-sig,
.moz-signature {
  color: gray;
}

The following prefs work (they are added per style= attribute to <blockquote>
and wrapping <div> respectively):
Quote size, quote text style (bold, italic)
Variable width font

FYI: No relevant checkins to mozTXTToHTMLConv, so it's likely to be a regression
in Gecko or Mailnews XUL.

I would appreciate a fix well before mozilla1.0 - I spent quite some time to get
it all look good and this bug messes it up.
Keywords: mozilla1.0, regression
In win32 build 2001051920, win98SE (Classic theme)

user_pref("mail.quoted_graphical", false);

no longer works. Blue bars are displayed on all quoted text. It was working in
build 051704.
> It was working in build 051704.

Oh, this seems to be a different bug, then. Please file a new bug and quote the
number here. Thanks.

> Oh, this seems to be a different bug, then. Please file a new bug and quote the
> number here. Thanks.

bug 81880.

I believe that bug 72646 a dup of this.

I state there:
> Started between 2001-03-13 and 2001-03-18.

Daniel Bratell says there:
> Removing 0.8.1 from keywords since this was introduced after the branch. 

but here I say that this bug appared in Mozilla 0.8.1 already. Not sure what's
the deal.

Anyways, looking for changes made between 2001-03-13 and 2001-03-18 (on trunk or
branch) might be rewarding.
*** Bug 72464 has been marked as a duplicate of this bug. ***
Assignee: sspitzer → mozilla
Component: Mail Window Front End → Themes
Keywords: review
Product: MailNews → Browser
Target Milestone: --- → mozilla0.9.3
I have a fix. Attaching.

The bug was caused by
@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
@namespace html url("http://www.w3.org/1999/xhtml");
which have been added in revision 1.4 of themes/modern/mailheader.css by hewitt,
r=lots of people.
I just commented out these lines, which caused no visible changes other than
fixing this bug. I tried to fix the bug by adding "html|", but that didn't work.

hewitt, please review.
Keywords: modern
*** Bug 78447 has been marked as a duplicate of this bug. ***
*** Bug 83907 has been marked as a duplicate of this bug. ***
The patch might not fix all of the later mentioned problems (but probably will
fix many of them). We might need to file new bugs for remaining problems. But
the patch should at least fix the initially described bug.

I also noticed that the quote style prefs don't work well ltogether with the
"Ignore Colors/Fonts from websites" prefs in Appearance. This is definitely a
separate problem, filed bug 89381 about it.
In accordance with Ben's duping, P/OS -> All, keywording.
Keywords: mozilla0.9.2, nsbeta1, nsCatFood
OS: Linux → All
Hardware: PC → All
I am able to turn off HTML style quoting in build 2001070808 but the old style
way of quoting with > are all bunched together instead of having spaces like in NS4.

The way it is now:

> quote one
>> two
>>> three

Instead of the old way:

> quote one
> > two
> > > three

Which makes it easier to read when you have a lot of levels of replies.  Can
this be fixed to have spaces in between the quotes? (>)


wjbell, look at the source. If it's identical to the source (I think it is),
then no, it cannot be fixed, and it was that way because this bug (the
regression) came up.

> Which makes it easier to read

That's exactly the idea of the grey bars *g*. /me hides
Hmm, why can't it be fixed?  The browser writes in the > for replies right?  If
It can write in >> why not > >?  I'm not saying use CSS to space them, I'm
saying have the browser write them spaced in the first place. (not trying to be
a smartass, really don't understand)
Then, you are in the wrong bug. This one is about display only. File a new one
and we can discuss there (it will be WONTFIX or INVALID probably, but we have a
forum to discuss).
Is this bug dealing with the quoted text sometimes looking like this: "||" and
sometimes like this: "|| >>"? It's confusing & inconsistent. What are the bars,
what are the ">"? :(

BTW. Why is this bug in "Themes" component and "browser" product? Shouldn't it
be mail/news and front-end?
would like it see considered for the branch. highly visible.

Lairo: Yes. No (because it's a bug in the Mailnews *theme*).
Keywords: nsBranch
There are technical reasons for the tight '>':s. They need to be together to 
convey certain information regarding flow and quotes (as specified in RFC 2646). 
If parsed according to that RFC and displayed with block quotes there won't be 
any problem, but as soon as old/non conforming mail programs and conforming mail 
programs (such as Mozilla) are mixed, the ">>>>>" will be visible. The same if 
you have choosen to use the plain text editor.

I don't really see a fix to this other than parsing and displaying something 
else from what came from the net. That's not easy and has many potential 
problems. The pure ASCII-are lovers being only one.

*** Bug 90834 has been marked as a duplicate of this bug. ***
PDT,
this bug fix fixes several severe style problems in plaintext messages:
1. We have "double quotes", i.e. *both* the blue bar and ">", which is ugly and
confusing
2. Several preferences are simply ignored, including the fixed width vs.
variable width font pref.
3. I think, the font size is currently way too large.
4. Others
In short, plaintext display style is all messed up, because most of the style
rules are not applied.
It is a regression in the Modern theme caused by hewitt. I would like this fix
to go in the 0.9.2 branch, with your agreement.

I asked hewitt for review almost 3 weeks ago. I mailed him 2 times, with no
answer. What should I do?
Ben, sorry but it's just too late for this type of change.  Please get it in on
the trunk and it'll catch the next release.
oh. :-(((

sr=hewitt
sr=ben@netscape.com, r=blake, sr=hewitt
Ben, can you ask for this fix to be accepted for 0.9.3? I've waited long for
this to be fixed and wouldn't want it to miss yet another milestone.

(And maybe it can somewhat silence the ranting in n.p.m.mailnews)
I've read through this bug and I'm confused. What >>I<< want is for Mozilla to
show me all messages >>EXACTLY<< as they were received. If a line starts with
">>", then that's what I want to see. If it starts with "> >", then that's what
I want to see. I don't want my mail client changing anything in what the sender
wrote. As I read throught this, it seems the choice is "| |" or "> >" if Mozilla
thinks the line starts with some kind of quoting. I don't care what Mozilla
thinks; I don't want it to think. Just show me the original text.
Dave Close,
this bug is about a regression. The goal is clear: Make the message look as it
were a few months ago. If you disagree with that, please discuss on the
newsgroup. BTW: This has been discussed to death already, and I answered your
questions in previous discussions already, IIRC.
blizzard worte:
> That's mostly cosmetic. I don't think that it's 0.9.3 material since we're
> trying to wrap this up.

Holger Metzger wrote on .mail-news:
> I prefer the Modern theme, but this problem makes it unusable.
Why do I get the feeling that the people down prioritizing this bug isn't using 
mail and news in Mozilla themselves.

Missed 0.9.3.
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Ben, you have checkin right don't you? How about checking this in so that we can
forget about it?

Daniel, I am busy atm with the Beonex release. I will nevertheless try to check in.
I always have the blue bar and the ">" displayed simultaneously when the message
I was replying to had not been in format=flowed, and in addition I always have
the problem when I disable usage of format=flowed completely ( with
user_pref("mailnews.display.disable_format_flowed_support", true);)

Please someone fix this... I really prefer the Modern theme :)
Checked in. Made 0.9.4 by a few hours - phew!
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
When did I review this?
2001-07-26, CET, #mozilla:
06:39:50 <BenB> blake: so, can I have that stupid sr now?
06:40:07 <blake_> r=me

Using build 2001-09-24 on winxp,linux & mac I don't get the 
blue bar when viewing a message that was replied to using plain text. 
I get a black bar.  I tested this in both Modern and Classic.
Also, I tested a plain text message sent with 4.7 which isn't in format=flowed 
and replied to it.  I did not get the blue bar and ">", it displays a black bar 
for the quoted text.  Verified.  If I should test some other scenario, please 
give the scenario.
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: