Last Comment Bug 763592 - Page reloads get treated as same-document location changes
: Page reloads get treated as same-document location changes
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All Android
: -- normal (vote)
: Firefox 16
Assigned To: away[Nov24,Dec5) Kartikaya Gupta (
: Sebastian Kaspari (:sebastian)
Depends on:
Blocks: 747883 759678
  Show dependency treegraph
Reported: 2012-06-11 11:32 PDT by away[Nov24,Dec5) Kartikaya Gupta (
Modified: 2012-06-13 17:22 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Make page reloads set !sameDocument (1.66 KB, patch)
2012-06-11 11:33 PDT, away[Nov24,Dec5) Kartikaya Gupta (
mark.finkle: review+
bugzilla: approval‑mozilla‑aurora+
bugzilla: approval‑mozilla‑beta+
Details | Diff | Splinter Review

Description away[Nov24,Dec5) Kartikaya Gupta ( 2012-06-11 11:32:20 PDT
Regression from bug 747883; the URL fixup stuff inadvertently treats page reloads as "spurious addition"s to the URL.
Comment 1 away[Nov24,Dec5) Kartikaya Gupta ( 2012-06-11 11:33:54 PDT
Created attachment 631962 [details] [diff] [review]
Make page reloads set !sameDocument
Comment 2 away[Nov24,Dec5) Kartikaya Gupta ( 2012-06-11 11:34:13 PDT
Also CC'ing ajuma in case he has any comments.
Comment 3 away[Nov24,Dec5) Kartikaya Gupta ( 2012-06-11 11:40:09 PDT
Noming this as it blocks bug 759678, which in turn could fix bug 721523, which is a blocker.
Comment 4 Johnathan Nightingale [:johnath] 2012-06-11 11:53:37 PDT
Not a blocker because bug 721523 is going to be wallpapered over AMO side, aiui. Would like, though (and feel free to approvalnom if appropriate).
Comment 5 away[Nov24,Dec5) Kartikaya Gupta ( 2012-06-11 12:19:54 PDT
Comment 6 Graeme McCutcheon [:graememcc] 2012-06-12 03:05:44 PDT
Comment 7 away[Nov24,Dec5) Kartikaya Gupta ( 2012-06-12 19:37:03 PDT
Comment on attachment 631962 [details] [diff] [review]
Make page reloads set !sameDocument

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 747883
User impact if declined: on page reload, the page might jump around during load, since we don't suspend viewport updates and user interaction.
Testing completed (on m-c, etc.): on m-c for a day
Risk to taking this patch (and alternatives if risky): mobile-only. potential risk of either regressing bug 747883 or not fully fixing the issues described in "user impact if declined"
String or UUID changes made by this patch: none

Also note that the patch on bug 759678 will be ineffective for page reloads without this patch.
Comment 8 Johnathan Nightingale [:johnath] 2012-06-13 12:25:50 PDT
Comment on attachment 631962 [details] [diff] [review]
Make page reloads set !sameDocument

Discussed in triage with kats - approved for b7. Go go go!
Comment 10 Kevin Brosnan [:kbrosnan] 2012-06-13 17:22:39 PDT
Verified on Firefox 14 beta 7 build 2

Note You need to log in before you can comment on or make changes to this bug.