Closed Bug 763592 Opened 14 years ago Closed 14 years ago

Page reloads get treated as same-document location changes

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox14 verified, firefox15 fixed, firefox16 fixed, blocking-fennec1.0 -, fennec15+)

Status:
RESOLVED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox14 --- verified
firefox15 --- fixed
firefox16 --- fixed
blocking-fennec1.0 --- -
fennec 15+ ---

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Make page reloads set !sameDocument
1.66 KB, patch
mfinkle
: review+
johnath
: approval-mozilla-aurora+
johnath
: approval-mozilla-beta+
Details | Diff | Splinter Review
Regression from bug 747883; the URL fixup stuff inadvertently treats page reloads as "spurious addition"s to the URL.
Attachment #631962 - Flags: review?(mark.finkle)
Also CC'ing ajuma in case he has any comments.
Noming this as it blocks bug 759678, which in turn could fix bug 721523, which is a blocker.
blocking-fennec1.0: --- → ?
Attachment #631962 - Flags: review?(mark.finkle) → review+
Not a blocker because bug 721523 is going to be wallpapered over AMO side, aiui. Would like, though (and feel free to approvalnom if appropriate).
tracking-fennec: --- → 15+
blocking-fennec1.0: ? → -
https://hg.mozilla.org/mozilla-central/rev/bed9bdc78e8c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 631962 [details] [diff] [review] Make page reloads set !sameDocument [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 747883 User impact if declined: on page reload, the page might jump around during load, since we don't suspend viewport updates and user interaction. Testing completed (on m-c, etc.): on m-c for a day Risk to taking this patch (and alternatives if risky): mobile-only. potential risk of either regressing bug 747883 or not fully fixing the issues described in "user impact if declined" String or UUID changes made by this patch: none Also note that the patch on bug 759678 will be ineffective for page reloads without this patch.
Attachment #631962 - Flags: approval-mozilla-beta?
Attachment #631962 - Flags: approval-mozilla-aurora?
Comment on attachment 631962 [details] [diff] [review] Make page reloads set !sameDocument Discussed in triage with kats - approved for b7. Go go go!
Attachment #631962 - Flags: approval-mozilla-beta?
Attachment #631962 - Flags: approval-mozilla-beta+
Attachment #631962 - Flags: approval-mozilla-aurora?
Attachment #631962 - Flags: approval-mozilla-aurora+
Verified on Firefox 14 beta 7 build 2
status-firefox14: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: