remove unnecessary application flags from webapp runtime's components.manifest

RESOLVED FIXED in Firefox 16

Status

Firefox Graveyard
Webapp Runtime
P3
normal
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: myk, Assigned: myk)

Tracking

14 Branch
Firefox 16
Bug Flags:
in-moztrap -

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 632078 [details] [diff] [review]
patch v1: removes application flags

The webapp runtime's components.manifest file restricts its instructions to the runtime via `application` flags.  But those are no longer necessary now that the webapp runtime files have been isolated into their own directory per bug 746156.  And the instructions registering most recent component added to the runtime (ContentPermission.js) do not have such flags.  None of them should.
Attachment #632078 - Flags: review?(benjamin)
(Assignee)

Comment 1

5 years ago
Note that this patch will conflict trivially with the fix for bug 752666, currently on inbound.
(In reply to Myk Melez [:myk] [@mykmelez] from comment #0)
> the webapp runtime files have been isolated into their own directory
> per bug 746156.

Will that allow us to get rid of the equivalent lines in the Firefox/Sync manifests as well? (I never quite understood why those included b2g/mobile, since none of that code gets used in either of those.)
(Assignee)

Comment 3

5 years ago
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #2)
> (In reply to Myk Melez [:myk] [@mykmelez] from comment #0)
> > the webapp runtime files have been isolated into their own directory
> > per bug 746156.
> 
> Will that allow us to get rid of the equivalent lines in the Firefox/Sync
> manifests as well?

Sadly, no, those lines remain necessary to prevent the runtime from loading Firefox/Sync components.  To make those lines unnecessary, we would have to separate Firefox from the GRE.


> (I never quite understood why those included b2g/mobile,
> since none of that code gets used in either of those.)

Sounds like a mistake that should be fixed.
(Assignee)

Updated

5 years ago
Priority: -- → P3
Target Milestone: --- → Firefox 16
Attachment #632078 - Flags: review?(benjamin) → review+
(Assignee)

Comment 4

5 years ago
Comment on attachment 632078 [details] [diff] [review]
patch v1: removes application flags

https://hg.mozilla.org/integration/mozilla-inbound/rev/55f8b9b957c3
Attachment #632078 - Flags: checkin+

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/55f8b9b957c3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Myk - Trying to understand if it's worth verifying this bug. How is an end-user affected by this implementation? Where would they see something different? Or is this just an internal code change?
Whiteboard: [qa?]
(Assignee)

Comment 7

5 years ago
This is just an internal code change.

Updated

5 years ago
Whiteboard: [qa?] → [qa-]

Updated

5 years ago
Flags: in-moztrap-

Updated

5 years ago
QA Contact: jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.