Error console looks wonky on OS X

RESOLVED FIXED in mozilla18

Status

Toolkit Graveyard
Error Console
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: Dolske, Assigned: evilpie)

Tracking

({regression})

Trunk
mozilla18
x86
Mac OS X
regression
Dependency tree / graph
Bug Flags:
in-testsuite -

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 632131 [details]
Screenshot w/ new + old console

Bug 760951 added a filter box to the error console, but made the appearance wonky on OS X... OS X convention is that the section "tabs" (all,errors,warning,etc -- not sure of the proper widget name) should be centered in the window. The addition of the filter box pushed them flush-left, which looks out of place.

Not sure what the solution is here. Re-centering the "tabs" would be a little tricky in XUL, and might still look odd with the filter field crowding it. Closest UI I can find is either a Finder window (which achieves balance by having navigation buttons on on the left), or Safari's own error console which uses a different widget style for the all/errors/warnings selection.

Updated

5 years ago
Keywords: regression
Sorry, I won't be of much help here, this was the first time I looked at XUL and I don't own an OS X system.
(Reporter)

Updated

5 years ago
Keywords: uiwanted

Comment 2

5 years ago
Move the filter box to ToolbarEval perhaps?

Comment 3

5 years ago
Created attachment 634830 [details] [diff] [review]
Proof of concept
tracking-firefox16: --- → +
Gavin, this is not something we would hold a release for - seems like a nice-to-have but it does work in it's current state. If you can get someone assigned to working on this we'll continue tracking but otherwise I'm inclined to untrack this based on lack of activity and a lack of serious user effect.
I disagree; I think it would be ridiculous to ship this as-is. The solutions aren't hard, we just need to pick one (either back out the patch that caused this, or take something like Neil's patch). I'll make sure that happens.
I backed bug 760591 out on Aurora for Firefox 16:
https://hg.mozilla.org/releases/mozilla-aurora/rev/5e6da3c55e7c
status-firefox16: --- → fixed
tracking-firefox17: --- → +
That previous comment should have said "... backed out bug 760951 ..." (note the typo in the bug number). The commit message had the correct bug number.
Well can we take Neil's patch for this cycle?
Does it work? Can you take this bug? If not we'll need to just keep backing this patch out.
I talked with Tom at MozCamp and we think that a filter toolbar, similar to the find bar for the browser, will work here and won't make any of the platforms look awkward.

Tom, would you like to work on this?
Yep I am looking into this.
Assignee: nobody → evilpies
Status: NEW → ASSIGNED
Created attachment 660057 [details] [diff] [review]
filter at the bottom

How would you like this? http://imgur.com/RNjNU
Would appreciate somebody testing this on Mac this time :)
Attachment #634830 - Attachment is obsolete: true
Attachment #660057 - Flags: feedback?(jaws)
Comment on attachment 660057 [details] [diff] [review]
filter at the bottom

Review of attachment 660057 [details] [diff] [review]:
-----------------------------------------------------------------

I tested this out on OS X and it looks good to me. I think this is a reasonable compromise that will allow us to ship this feature.
Attachment #660057 - Flags: feedback?(jaws) → review+
So should I land this?
Comment on attachment 660057 [details] [diff] [review]
filter at the bottom

This looks pretty good on windows now and sort of weird with it moved to the bottom, I don't want to make a change that affects all platforms just to fix one without at least checking if UX are ok with this. Screenshot in comment 12.
Attachment #660057 - Flags: ui-review?(bdils.mozilla)
(In reply to Tom Schuster from comment #12)
> How would you like this? http://imgur.com/RNjNU

Bugzilla accepts image attachments too, you know ;-)
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #9)
> Does it work? Can you take this bug? If not we'll need to just keep backing
> this patch out.

Given that this is blocked on UI review can someone nominate and backout on Aurora 17 before we go to Beta channel?
Comment on attachment 660057 [details] [diff] [review]
filter at the bottom

I don't think we need to block on ui-review, this is hidden-by-default UI.
Attachment #660057 - Flags: ui-review?(bdils.mozilla)
Keywords: uiwanted → checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/71c76fb26e9e
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/71c76fb26e9e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
(In reply to Dave Townsend (:Mossop) from comment #15)
> Comment on attachment 660057 [details] [diff] [review]
> filter at the bottom
> 
> This looks pretty good on windows now and sort of weird with it moved to the
> bottom, I don't want to make a change that affects all platforms just to fix
> one without at least checking if UX are ok with this. Screenshot in comment
> 12.

One way to make it look less weird would be to use the standard widget for this type of UI, <statusbar>, rather than a plain hbox.

I was close to backing this out since it landed without toolkit peer review, but filed bug 799081 instead since the problem this solved on OS X is worse. (However since bug 760951 went through the same broken process and given bug 760951 comment 12 and below, maybe I should have backed out both patches.)
Depends on: 799081

Comment 22

5 years ago
Sorry but why has been the error console menu entry

web developer-error console removed?
(In reply to Sillius Soddus from comment #22)
> Sorry but why has been the error console menu entry
> 
> web developer-error console removed?

See https://bugzilla.mozilla.org/show_bug.cgi?id=602006
This is a regression tracked for 17 so an uplift nomination would be great here.
status-firefox17: --- → affected
Bug 760951 was backed out of Firefox 17. In the style of comment #6, I've marked this as fixed for fx17.
status-firefox17: affected → fixed

Updated

5 years ago
status-firefox16: fixed → unaffected
status-firefox17: fixed → unaffected
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.