Closed
Bug 763865
Opened 12 years ago
Closed 12 years ago
Layout tool is not positioned correctly when it is collapsed
Categories
(DevTools :: General, defect, P1)
DevTools
General
Tracking
(firefox15 verified)
VERIFIED
FIXED
Firefox 16
Tracking | Status | |
---|---|---|
firefox15 | --- | verified |
People
(Reporter: pauly, Unassigned)
References
Details
Attachments
(3 files, 1 obsolete file)
368.28 KB,
image/png
|
Details | |
378.23 KB,
image/png
|
Details | |
732 bytes,
patch
|
dcamp
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
STR: 1. Open the Inspector 2. Click on "Style" Actual results: The Layout tool is collapsed too much - see layout-bad.png Expected results: layout-good.png Expanding and then collapsing again the tool fix the problem
Reporter | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Can you reproduce on Firefox Nightly? Did it happen once or it happens every time?
Comment 3•12 years ago
|
||
I can't reproduce here. Can you reproduce on Mac and/or Linux?
Updated•12 years ago
|
Priority: -- → P1
Reporter | ||
Comment 4•12 years ago
|
||
I can always reproduce it on all platforms. Same behavior on Nightly.
Reporter | ||
Comment 5•12 years ago
|
||
In order to reproduce this, make sure the Layout tool didn't remain expanded from a previous use. It should be collapsed when opening the inspector/style, this happens only then.
(In reply to Paul Rouget [:paul] from comment #3) > I can't reproduce here. Can you reproduce on Mac and/or Linux? My STR on Win 7 with Nightly: 1) Open about:home 2) Enable Web Developer > Responsive Mode (or Ctrl+Shift+M) 3) Enable Web Developer > Inspect (or Ctrl+Shift+I) The footer of the layout tool is collapsed too much. Click on a page element to inspect, the footer returns to its normal height.
Comment 7•12 years ago
|
||
Comment 8•12 years ago
|
||
Comment on attachment 634917 [details] [diff] [review] v1 That works. I would prefer to do that in CSS, but not sure how.
Attachment #634917 -
Flags: review?(dcamp)
Comment 9•12 years ago
|
||
What does this do, exactly?
Comment 10•12 years ago
|
||
(In reply to Dave Camp (:dcamp) from comment #9) > What does this do, exactly? This adds an inline element, forcing its parents to get the correct height. But I guess we don't need to have the full height, only the correct position.
Comment 11•12 years ago
|
||
Updated•12 years ago
|
Attachment #634917 -
Attachment is obsolete: true
Attachment #634917 -
Flags: review?(dcamp)
Comment 12•12 years ago
|
||
So apparently, using `vertical-align:top` works. But I don't understand why there's a gap in the first place. See http://bl.ocks.org/d/2964774/bug.html (gap between the red line and the dotted line). As soon as you add content to the span or use vertical-align:top, the gap disappears.
Updated•12 years ago
|
Attachment #635226 -
Flags: review?(dcamp)
Comment 13•12 years ago
|
||
And we probably want to get that in Aurora as well.
Updated•12 years ago
|
Attachment #635226 -
Flags: review?(dcamp) → review+
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Comment 14•12 years ago
|
||
Comment on attachment 635226 [details] [diff] [review] v2 [Approval Request Comment] Bug caused by (feature/regressing bug #): new feature User impact if declined: layout view UI looks weird Testing completed (on m-c, etc.): local Risk to taking this patch (and alternatives if risky): One CSS line String or UUID changes made by this patch: no
Attachment #635226 -
Flags: approval-mozilla-aurora?
Comment 15•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/848ac784a4ba
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 16•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/848ac784a4ba
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
Reporter | ||
Comment 17•12 years ago
|
||
Verified fixed on Nightly 16.0a1 (2012-06-26) on Win 7, Ubuntu 12.04 and Mac OS X 10.6.
Status: RESOLVED → VERIFIED
Comment 18•12 years ago
|
||
Comment on attachment 635226 [details] [diff] [review] v2 [Triage Comment] Looks super low risk. Approved for Aurora 15.
Attachment #635226 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 19•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/1c5edd36d1fd
status-firefox15:
--- → fixed
Reporter | ||
Comment 20•12 years ago
|
||
Verified fixed on Aurora 15.0a2 (2012-07-01) on Win 7, Ubuntu 12.04 and Mac OS X 10.6.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•