The default bug view has changed. See this FAQ.

Layout tool is not positioned correctly when it is collapsed

VERIFIED FIXED in Firefox 15

Status

()

Firefox
Developer Tools
P1
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: pauly, Unassigned)

Tracking

Trunk
Firefox 16
Points:
---

Firefox Tracking Flags

(firefox15 verified)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 632180 [details]
layout-bad

STR:
1. Open the Inspector
2. Click on "Style"

Actual results:
The Layout tool is collapsed too much - see layout-bad.png

Expected results:
layout-good.png
Expanding and then collapsing again the tool fix the problem
(Reporter)

Comment 1

5 years ago
Created attachment 632181 [details]
layout-good

Comment 2

5 years ago
Can you reproduce on Firefox Nightly?
Did it happen once or it happens every time?

Comment 3

5 years ago
I can't reproduce here. Can you reproduce on Mac and/or Linux?

Updated

5 years ago
Priority: -- → P1
(Reporter)

Comment 4

5 years ago
I can always reproduce it on all platforms. Same behavior on Nightly.
(Reporter)

Comment 5

5 years ago
In order to reproduce this, make sure the Layout tool didn't remain expanded from a previous use. It should be collapsed when opening the inspector/style, this happens only then.

Comment 6

5 years ago
(In reply to Paul Rouget [:paul] from comment #3)
> I can't reproduce here. Can you reproduce on Mac and/or Linux?

My STR on Win 7 with Nightly:

1) Open about:home
2) Enable Web Developer > Responsive Mode (or Ctrl+Shift+M)
3) Enable Web Developer > Inspect (or Ctrl+Shift+I)

The footer of the layout tool is collapsed too much.
Click on a page element to inspect, the footer returns to its normal height.

Comment 7

5 years ago
Created attachment 634917 [details] [diff] [review]
v1

Comment 8

5 years ago
Comment on attachment 634917 [details] [diff] [review]
v1

That works. I would prefer to do that in CSS, but not sure how.
Attachment #634917 - Flags: review?(dcamp)

Comment 9

5 years ago
What does this do, exactly?

Comment 10

5 years ago
(In reply to Dave Camp (:dcamp) from comment #9)
> What does this do, exactly?

This adds an inline element, forcing its parents to get the correct height.
But I guess we don't need to have the full height, only the correct position.

Comment 11

5 years ago
Created attachment 635226 [details] [diff] [review]
v2

Updated

5 years ago
Attachment #634917 - Attachment is obsolete: true
Attachment #634917 - Flags: review?(dcamp)

Comment 12

5 years ago
So apparently, using `vertical-align:top` works.

But I don't understand why there's a gap in the first place.
See http://bl.ocks.org/d/2964774/bug.html (gap between the red line and the dotted line).
As soon as you add content to the span or use vertical-align:top, the gap disappears.

Updated

5 years ago
Attachment #635226 - Flags: review?(dcamp)

Comment 13

5 years ago
And we probably want to get that in Aurora as well.

Updated

5 years ago
Attachment #635226 - Flags: review?(dcamp) → review+

Updated

5 years ago
Whiteboard: [land-in-fx-team]

Comment 14

5 years ago
Comment on attachment 635226 [details] [diff] [review]
v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature
User impact if declined: layout view UI looks weird
Testing completed (on m-c, etc.): local
Risk to taking this patch (and alternatives if risky): One CSS line 
String or UUID changes made by this patch: no
Attachment #635226 - Flags: approval-mozilla-aurora?

Comment 15

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/848ac784a4ba
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/848ac784a4ba
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
(Reporter)

Comment 17

5 years ago
Verified fixed on Nightly 16.0a1 (2012-06-26) on Win 7, Ubuntu 12.04 and Mac OS X 10.6.
Status: RESOLVED → VERIFIED
Comment on attachment 635226 [details] [diff] [review]
v2

[Triage Comment]
Looks super low risk. Approved for Aurora 15.
Attachment #635226 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/1c5edd36d1fd
status-firefox15: --- → fixed
(Reporter)

Comment 20

5 years ago
Verified fixed on Aurora 15.0a2 (2012-07-01) on Win 7, Ubuntu 12.04 and Mac OS X 10.6.
status-firefox15: fixed → verified
You need to log in before you can comment on or make changes to this bug.