747220 - [layout view] update the UI

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Paul Rouget [:paul]]

The layout view needs proper icons and a ui-review.

Comment 1

[Paul Rouget [:paul]]

Attachment: screenshot - layoutview closed

Comment 2

[Paul Rouget [:paul]]

Attachment: screenshot - layoutview open

Comment 3

[Paul Rouget [:paul]]

The current icons are just placeholders. We need 2 appropriate icons.

Comment 4

[Paul Rouget [:paul]]

Attachment: screenshot - layoutview open - no node selected

Comment 5

[Paul Rouget [:paul]]

Attachment: screenshot - layoutview closed - no node selected

Comment 6

[Dave Camp (:dcamp)]

Shorlander, is this bug on your radar?

Comment 7

[Stephen Horlander [:shorlander]]

(In reply to Dave Camp (:dcamp) from comment #6)
> Shorlander, is this bug on your radar?

Yes! I am working on it today and going to talk to Paul tomorrow.

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: Layout View Mockup

Looks good!

Thoughts:
- With no node selected keep the diagram boxes and borders, just remove the information
- The dimensions seems self-explanatory so probably don't need the "Element Size:" text
- Change the collapsed view be textured like other toolbar and remove the grid.

Comment 9

[Stephen Horlander [:shorlander]]

Attachment: Expand/Collapse Image

Comment 10

[Paul Rouget [:paul]]

Attachment: patch v0.999

Comment 11

[Paul Rouget [:paul]]

Attachment: patch v0.999

Comment 12

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 13

[Paul Rouget [:paul]]

Comment on attachment 627662 [details] [diff] [review]
patch v1

Some tweaks to match Shorlander's mockups.

Comment 14

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/bdc9a8045490

Comment 15

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/bdc9a8045490

Comment 16

[Paul Silaghi, QA [:pauly]]

(In reply to Stephen Horlander from comment #8)
> Created attachment 627356 [details]
> Layout View Mockup
> 
> Looks good!
> 
> Thoughts:
> - With no node selected keep the diagram boxes and borders, just remove the
> information

Select a node, then press CTRL+SHIFT+I and move the mouse --> the upper left layout coordinates for the previously selected node are still displayed. Is this expected ?

Comment 17

[Paul Rouget [:paul]]

(In reply to Paul Silaghi [QA] from comment #16)
> (In reply to Stephen Horlander from comment #8)
> > Created attachment 627356 [details]
> > Layout View Mockup
> > 
> > Looks good!
> > 
> > Thoughts:
> > - With no node selected keep the diagram boxes and borders, just remove the
> > information
> 
> Select a node, then press CTRL+SHIFT+I and move the mouse --> the upper left
> layout coordinates for the previously selected node are still displayed. Is
> this expected ?

It is. But not sure it's the right way to do it.
If you think it's confusing, please file a bug.

Comment 18

[Paul Silaghi, QA [:pauly]]

Thanks Paul.
I'm just saying it would look normal to me if all other information are removed when no node is selected, the same should be these top two coordinates.
Bug 766526 filed.