[layout view] update the UI

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: paul, Unassigned)

Tracking

Trunk
Firefox 15
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
The layout view needs proper icons and a ui-review.
(Reporter)

Comment 1

5 years ago
Created attachment 622377 [details]
screenshot - layoutview closed
(Reporter)

Comment 2

5 years ago
Created attachment 622378 [details]
screenshot - layoutview open
(Reporter)

Updated

5 years ago
Attachment #622377 - Flags: ui-review?(shorlander)
(Reporter)

Updated

5 years ago
Attachment #622378 - Flags: ui-review?(shorlander)
(Reporter)

Comment 3

5 years ago
The current icons are just placeholders. We need 2 appropriate icons.
(Reporter)

Comment 4

5 years ago
Created attachment 623628 [details]
screenshot - layoutview open - no node selected
Attachment #623628 - Flags: ui-review?(shorlander)
(Reporter)

Comment 5

5 years ago
Created attachment 623629 [details]
screenshot - layoutview closed - no node selected
Attachment #623629 - Flags: ui-review?(shorlander)

Comment 6

5 years ago
Shorlander, is this bug on your radar?
(In reply to Dave Camp (:dcamp) from comment #6)
> Shorlander, is this bug on your radar?

Yes! I am working on it today and going to talk to Paul tomorrow.
Created attachment 627356 [details]
Layout View Mockup

Looks good!

Thoughts:
- With no node selected keep the diagram boxes and borders, just remove the information
- The dimensions seems self-explanatory so probably don't need the "Element Size:" text
- Change the collapsed view be textured like other toolbar and remove the grid.
Created attachment 627357 [details]
Expand/Collapse Image
Attachment #622377 - Flags: ui-review?(shorlander) → ui-review-
Attachment #622378 - Flags: ui-review?(shorlander) → ui-review-
Attachment #623628 - Flags: ui-review?(shorlander) → ui-review-
Attachment #623629 - Flags: ui-review?(shorlander) → ui-review-
(Reporter)

Comment 10

5 years ago
Created attachment 627569 [details] [diff] [review]
patch v0.999
(Reporter)

Comment 11

5 years ago
Created attachment 627660 [details] [diff] [review]
patch v0.999
(Reporter)

Updated

5 years ago
Attachment #627569 - Attachment is obsolete: true
(Reporter)

Comment 12

5 years ago
Created attachment 627662 [details] [diff] [review]
patch v1
(Reporter)

Updated

5 years ago
Attachment #627660 - Attachment is obsolete: true
(Reporter)

Comment 13

5 years ago
Comment on attachment 627662 [details] [diff] [review]
patch v1

Some tweaks to match Shorlander's mockups.
Attachment #627662 - Flags: review?(dcamp)

Updated

5 years ago
Attachment #627662 - Flags: review?(dcamp) → review+
(Reporter)

Updated

5 years ago
Whiteboard: [land-in-fx-team]

Comment 14

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/bdc9a8045490
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/bdc9a8045490
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Depends on: 763865
(In reply to Stephen Horlander from comment #8)
> Created attachment 627356 [details]
> Layout View Mockup
> 
> Looks good!
> 
> Thoughts:
> - With no node selected keep the diagram boxes and borders, just remove the
> information

Select a node, then press CTRL+SHIFT+I and move the mouse --> the upper left layout coordinates for the previously selected node are still displayed. Is this expected ?
(Reporter)

Comment 17

5 years ago
(In reply to Paul Silaghi [QA] from comment #16)
> (In reply to Stephen Horlander from comment #8)
> > Created attachment 627356 [details]
> > Layout View Mockup
> > 
> > Looks good!
> > 
> > Thoughts:
> > - With no node selected keep the diagram boxes and borders, just remove the
> > information
> 
> Select a node, then press CTRL+SHIFT+I and move the mouse --> the upper left
> layout coordinates for the previously selected node are still displayed. Is
> this expected ?

It is. But not sure it's the right way to do it.
If you think it's confusing, please file a bug.
Depends on: 766526
Thanks Paul.
I'm just saying it would look normal to me if all other information are removed when no node is selected, the same should be these top two coordinates.
Bug 766526 filed.
You need to log in before you can comment on or make changes to this bug.