The default bug view has changed. See this FAQ.

Remove our prefetch when READOPS=0 on windows

RESOLVED FIXED in mozilla16

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: (dormant account), Assigned: glandium)

Tracking

unspecified
mozilla16
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
bug 757215 shows that my heuristic a slight loss. We should focus any profiling/optimization on the case where we know prefetch is nuked for us, ie bug 692255.
(Assignee)

Comment 1

5 years ago
Created attachment 632586 [details] [diff] [review]
Only rely on the maintenance service to enable preload on Windows

I think the experiment we were talking about yesterday would be a separate bug.
Attachment #632586 - Flags: review?(taras.mozilla)
(Assignee)

Comment 2

5 years ago
Created attachment 632636 [details] [diff] [review]
Only rely on the maintenance service to enable preload on Windows

Need to leave ioCounters there because it's used for *GLUESTARTUP_READ_OPS and *GLUESTARTUP_READ_TRANSFER.
Attachment #632636 - Flags: review?(taras.mozilla)
(Assignee)

Updated

5 years ago
Attachment #632586 - Attachment is obsolete: true
Attachment #632586 - Flags: review?(taras.mozilla)
Comment on attachment 632636 [details] [diff] [review]
Only rely on the maintenance service to enable preload on Windows

Review of attachment 632636 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/nsBrowserApp.cpp
@@ -234,5 @@
>    if (IsPrefetchDisabledViaService()) {
>      preloadReason = PRELOAD_SERVICE;
> -  } else if ((gotCounters && !ioCounters.ReadOperationCount)) {
> -    preloadReason = PRELOAD_IOCOUNT;
> -  }

You need to keep this closing brace otherwise it won't compile.
(Assignee)

Comment 4

5 years ago
Created attachment 632667 [details] [diff] [review]
Only rely on the maintenance service to enable preload on Windows

(In reply to Brian R. Bondy [:bbondy] from comment #3)
> @@ -234,5 @@
> >    if (IsPrefetchDisabledViaService()) {
> >      preloadReason = PRELOAD_SERVICE;
> > -  } else if ((gotCounters && !ioCounters.ReadOperationCount)) {
> > -    preloadReason = PRELOAD_IOCOUNT;
> > -  }
> 
> You need to keep this closing brace otherwise it won't compile.

Yeah, try just told me so :)
Attachment #632667 - Flags: review?(taras.mozilla)
(Assignee)

Updated

5 years ago
Attachment #632636 - Attachment is obsolete: true
Attachment #632636 - Flags: review?(taras.mozilla)
(Reporter)

Updated

5 years ago
Attachment #632667 - Flags: review?(taras.mozilla) → review+
Blocks: 764905
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/da76a072b2b0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.