Closed
Bug 764905
Opened 12 years ago
Closed 12 years ago
Randomly flip preload on/off, independent of whether update service deleted prefetch
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: taras.mozilla, Assigned: bbondy)
References
Details
Attachments
(1 file, 1 obsolete file)
4.60 KB,
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
Should add a new (binary?) histogram to indicate whether we decided to prefetch or not. I think 50% rand() is fine for this, unless there are other startup experiments we want to do at the same time.
Comment 1•12 years ago
|
||
I guess we want to avoid this spilling on some channels. Which channels would it be suitable for? aurora + nightly? only nightly?
Reporter | ||
Comment 2•12 years ago
|
||
Aurora/nightly sounds good to me.
Assignee | ||
Comment 3•12 years ago
|
||
Maybe we should try no prefetch + no preload?
Reporter | ||
Comment 4•12 years ago
|
||
(In reply to Brian R. Bondy [:bbondy] from comment #3)
> Maybe we should try no prefetch + no preload?
Worth a try, but that requires being able to randomly remove prefetch files. Seems like something best done in own bug.
Assignee | ||
Comment 5•12 years ago
|
||
Specifically I'd like to see if no prefetch + no preload is faster than no prefetch + preload. So both have no prefetch.
Assignee | ||
Updated•12 years ago
|
Assignee: mh+mozilla → netzen
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #633340 -
Flags: review?(taras.mozilla)
Reporter | ||
Comment 7•12 years ago
|
||
Comment on attachment 633340 [details] [diff] [review]
Patch v1.
r+ if you change STARTUP_USING_PRELOAD to STARTUP_USING_PRELOAD_TRIAL or something. It's ok to reuse a histogram for a slightly different meaning, not ok to change histogram bucket distribution, it really confuses our frontend.
Attachment #633340 -
Flags: review?(taras.mozilla) → review+
Assignee | ||
Comment 8•12 years ago
|
||
Made histogram name change.
Attachment #633340 -
Attachment is obsolete: true
Attachment #633507 -
Flags: review+
Assignee | ||
Comment 9•12 years ago
|
||
Target Milestone: --- → mozilla16
Comment 10•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•