Last Comment Bug 764905 - Randomly flip preload on/off, independent of whether update service deleted prefetch
: Randomly flip preload on/off, independent of whether update service deleted p...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: unspecified
: x86_64 Windows 7
: -- normal (vote)
: mozilla16
Assigned To: Brian R. Bondy [:bbondy]
:
:
Mentors:
Depends on: 764019
Blocks: 765850 770874 771745
  Show dependency treegraph
 
Reported: 2012-06-14 10:45 PDT by (dormant account)
Modified: 2012-07-06 20:10 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1. (4.45 KB, patch)
2012-06-14 17:58 PDT, Brian R. Bondy [:bbondy]
taras.mozilla: review+
Details | Diff | Splinter Review
Patch v2 (4.60 KB, patch)
2012-06-15 07:16 PDT, Brian R. Bondy [:bbondy]
netzen: review+
Details | Diff | Splinter Review

Description (dormant account) 2012-06-14 10:45:45 PDT
Should add a new (binary?) histogram to indicate whether we decided to prefetch or not. I think 50% rand() is fine for this, unless there are other startup experiments we want to do at the same time.
Comment 1 Mike Hommey [:glandium] 2012-06-14 10:47:53 PDT
I guess we want to avoid this spilling on some channels. Which channels would it be suitable for? aurora + nightly? only nightly?
Comment 2 (dormant account) 2012-06-14 10:52:15 PDT
Aurora/nightly sounds good to me.
Comment 3 Brian R. Bondy [:bbondy] 2012-06-14 12:39:42 PDT
Maybe we should try no prefetch + no preload?
Comment 4 (dormant account) 2012-06-14 12:47:56 PDT
(In reply to Brian R. Bondy [:bbondy] from comment #3)
> Maybe we should try no prefetch + no preload?

Worth a try, but that requires being able to randomly remove prefetch files. Seems like something best done in own bug.
Comment 5 Brian R. Bondy [:bbondy] 2012-06-14 12:49:17 PDT
Specifically I'd like to see if no prefetch + no preload is faster than no prefetch + preload.  So both have no prefetch.
Comment 6 Brian R. Bondy [:bbondy] 2012-06-14 17:58:57 PDT
Created attachment 633340 [details] [diff] [review]
Patch v1.
Comment 7 (dormant account) 2012-06-14 19:53:32 PDT
Comment on attachment 633340 [details] [diff] [review]
Patch v1.

r+ if you change STARTUP_USING_PRELOAD to STARTUP_USING_PRELOAD_TRIAL or something. It's ok to reuse a histogram for a slightly different meaning, not ok to change histogram bucket distribution, it really confuses our frontend.
Comment 8 Brian R. Bondy [:bbondy] 2012-06-15 07:16:44 PDT
Created attachment 633507 [details] [diff] [review]
Patch v2

Made histogram name change.
Comment 9 Brian R. Bondy [:bbondy] 2012-06-16 10:45:28 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/6291213e96ee
Comment 10 Ryan VanderMeulen [:RyanVM] 2012-06-16 19:41:18 PDT
https://hg.mozilla.org/mozilla-central/rev/6291213e96ee

Note You need to log in before you can comment on or make changes to this bug.