764144 - Disable telemetry on Fennec Beta

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 762620 has details on idle-daily firing too often. This causes telemetry to send data too often. This causes too much data to be sent, which is bad for mobile data plans.

The short term fix for the next beta is to hide any UI for telemetry (doorhanger and settings pref) so telemetry is left disabled by default.

We might even want to force telemetry to be turned back off if it was enabled previously.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: patch

Simple patch that should disable telemetry and remove the UI.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Lots of data is sent
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 632394 [details] [diff] [review]
patch

This seems to cover everything we need to address:
* telemetry is disabled via pref
* a doorhanger will never prompt
* the pref in Settings is gone
* we revert the user pref if the user has ever enabled telemetry in a previous beta

Let's land on beta and then QA can test a TB build.

Comment 3

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-beta/rev/271b0e7e0728

I also added these lines so users get prompted again when we re-enable telemetry:
+    Services.prefs.clearUserPref("toolkit.telemetry.prompted");
+    Services.prefs.clearUserPref("toolkit.telemetry.rejected");

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Telemetry is already disabled due to bug 763991 and bug 762590 being merged.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

To make it more clear: it's disabled because the fix for bug 763991 is *not* merged (and should not be merged) while the one for bug 762590 *is*.

The latter makes telemetry respect the MOZ_TELEMETRY_REPORTING setting, and the former would enable that setting. It is currently not enabled, and telemetry will now respect that.

Comment 6

[Aaron Train [:aaronmt]]

Verified disabled on 14.0b7. Confirming 14.0b6 enabled pref: toolkit.telemetry.enabled is valued at false

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Need to evaluate whether to enable bug 763991 and back this one out?

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

this has been backed out in bug 772075