76424 - [Installer] Enter button from keyboard does not select OK/Cancel from Items to Install dialog

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Jimmy Lee]

Build: 2001-04-17-09-trunk(WIN), 2001-04-17-04-trunk(MAC), 
2001-04-17-09-trunk(LINUX)

1. From http://jimbob/trigger3.html, click Trigger case button for any test
2. Press <Enter> from keyboard to select default OK button

RESULT:
Nothing happens.

EXPECTED RESULT:
OK button should be selected.

Comment 1

[Jimmy Lee]

Nominating for Beta.  This is fundamental behavior that is missing that was 
present in 6.0.

Comment 2

[Syd Logan]

Doesn't look like we used the standard button overlays, I'll look into this.

Comment 3

[Skewer]

Works for me in build 20010505 Win98. Enter key chooses "OK" on confirm dialog.
Although is this really what we want?

Comment 4

[Skewer]

Oops, this bug doesn't appear to be the same thing upon (much) closer
inspection. The behavior I'm describing is in the JS confirm dialog in the browser.

Comment 5

[Jimmy Lee]

Rewording Summary to avoid confusion with JS confirm.

Comment 6

[Syd Logan]

this is broken in other apps as well. let's hope it gets fixed. marking - since
it is an annoyance but we can ship.

Comment 7

[Jimmy Lee]

Adding keyword regression.

Comment 8

[Jimmy Lee]

Talking to John Morrison who tests XP Toolkit/Widgets, he doesn't know of any 
outstanding problems with <Enter> selecting the default button.  This is 
definitely still a problem with XPInstall's Items to Install dialog.

Comment 9

[Jimmy Lee]

Nominating.

Comment 10

[saari (gone)]

needs to be fixed for accessiblity

Comment 11

[Syd Logan]

curt

Comment 12

[Jimmy Lee]

Saari points it out.  We have an accessiblity problem with this not working. 
Let's get this one done.

Comment 13

[Jimmy Lee]

Build: 2002-01-23-09-trunk(WIN), 2002-01-23-08-trunk(LINUX),
2002-01-23-08-trunk(MAC)

Well, it seems that the Enter key selects OK now for Windows and Linux. 
Macintosh still does not select Install button.  But tabbing to Cancel and
pressing Enter key unexpectedly selects OK for Windows and Linux.  Updating
Summary to mention Cancel button.

Comment 14

[Daniel Veditz [:dveditz]]

I'll take this for now since I'm reworking these dialogs for embedding. If the
fix for this doesn't fall out of that re-working I'll pass it on to dprice instead.

Comment 15

[Jaime Rodriguez, Jr.]

ADT3 per ADT/XPInstall triage.

Comment 16

[Daniel Veditz [:dveditz]]

Attachment: Don't want the default dialogKeys behavior

Comment 17

[Daniel Veditz [:dveditz]]

curt, could I get an r= from you?

Comment 18

[Curt Patrick (gone)]

Comment on attachment 76710 [details] [diff] [review]
Don't want the default dialogKeys behavior

r=curt

Comment 19

[Joe Hewitt (gone)]

Comment on attachment 76710 [details] [diff] [review]
Don't want the default dialogKeys behavior

sr=hewitt

Comment 20

[Asa Dotzler [:asa]]

Comment on attachment 76710 [details] [diff] [review]
Don't want the default dialogKeys behavior

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 21

[Daniel Veditz [:dveditz]]

Fix checked in.

Comment 22

[Jimmy Lee]

Build: 2002-04-10-14-1.0.0(WIN), 2002-04-11-08-trunk(MAC 9.x and X),
2002-04-11-09-1.0.0(LINUX)

Looks good.  Enter key does select Install button.

Comment 23

[Syd Logan]

Is this checked into the branch? If so, please add fixed1.0.0 keyword. Otherwise
add adt1.0.0 keyword to nominate for branch.

Comment 24

[Daniel Veditz [:dveditz]]

This was checked in before there was a branch.

Comment 25

[Jimmy Lee]

I am confirming what Dan states.  This has been good on the branch.