764346 - Error console filter doesn't match address of source

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[Geoff Lankow (:darktrojan)]

Filtering for 'bugz' on the error console will show the messages that match, but not the CSS warnings about bugzilla. We should test against the address too.

Comment 1

[Tom S [:evilpie]]

Sure, I can fix this easily. At the moment, I only matched against the actually message (msg) part. One easy catch all solution would be to match against the stringified entry.

Comment 2

[Geoff Lankow (:darktrojan)]

I'm not sure, but I don't think we should filter on the line number or timestamp.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Looking at consoleBindings.xml (http://mxr.mozilla.org/mozilla-central/source/toolkit/components/console/content/consoleBindings.xml#196), I think we should filter on the following:

- msg
- href
- code
- line

I took a look at what the Web Console searches on and they include the following in attributes in their search (http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/HUDService.jsm#3945):

- aBody
- aSourceURL
- aSourceLine

Note that with the way that the Web Console does their searches, you can also include a ':' in your search filter and get back results even though that character is inserted between the URL and line number.

Comment 4

[Tom S [:evilpie]]

Attachment: Filter on addional attributes

Wow Jared thank you very much for this deep analysis!

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 633791 [details] [diff] [review]
Filter on addional attributes

Review of attachment 633791 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for not getting to this sooner. I will try to review it tomorrow.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 633791 [details] [diff] [review]
Filter on addional attributes

Review of attachment 633791 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good :)

Comment 7

[Tom S [:evilpie]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/16b70566af66

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/16b70566af66

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Backed out on Aurora for Firefox 16 because of bug 763821:
https://hg.mozilla.org/releases/mozilla-aurora/rev/5e6da3c55e7c

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: backout of patch for beta 17

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 760951, not ready to ship
User impact if declined: error console filters won't work great, need to back this out to back out bug 760951
Testing completed (on m-c, etc.): locally, and backed out on 16-aurora
Risk to taking this patch (and alternatives if risky): none expected
String or UUID changes made by this patch: none

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Backed out of firefox17-beta because bug 763821 didn't get fixed until firefox18:
https://hg.mozilla.org/releases/mozilla-beta/rev/4eaef696723e