Closed Bug 764346 Opened 9 years ago Closed 9 years ago

Error console filter doesn't match address of source


(Toolkit Graveyard :: Error Console, defect)

Not set


(firefox16 disabled, firefox17 disabled)

Tracking Status
firefox16 --- disabled
firefox17 --- disabled


(Reporter: darktrojan, Assigned: evilpie)




(2 files)

Filtering for 'bugz' on the error console will show the messages that match, but not the CSS warnings about bugzilla. We should test against the address too.
Sure, I can fix this easily. At the moment, I only matched against the actually message (msg) part. One easy catch all solution would be to match against the stringified entry.
Assignee: nobody → evilpies
I'm not sure, but I don't think we should filter on the line number or timestamp.
Looking at consoleBindings.xml (, I think we should filter on the following:

- msg
- href
- code
- line

I took a look at what the Web Console searches on and they include the following in attributes in their search (

- aBody
- aSourceURL
- aSourceLine

Note that with the way that the Web Console does their searches, you can also include a ':' in your search filter and get back results even though that character is inserted between the URL and line number.
Wow Jared thank you very much for this deep analysis!
Attachment #633791 - Flags: review?(jaws)
Comment on attachment 633791 [details] [diff] [review]
Filter on addional attributes

Review of attachment 633791 [details] [diff] [review]:

Sorry for not getting to this sooner. I will try to review it tomorrow.
Comment on attachment 633791 [details] [diff] [review]
Filter on addional attributes

Review of attachment 633791 [details] [diff] [review]:

Looks good :)
Attachment #633791 - Flags: review?(jaws) → review+
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 760951, not ready to ship
User impact if declined: error console filters won't work great, need to back this out to back out bug 760951
Testing completed (on m-c, etc.): locally, and backed out on 16-aurora
Risk to taking this patch (and alternatives if risky): none expected
String or UUID changes made by this patch: none
Attachment #669341 - Flags: approval-mozilla-beta?
Attachment #669341 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Backed out of firefox17-beta because bug 763821 didn't get fixed until firefox18:
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.