Closed Bug 764390 Opened 8 years ago Closed 4 years ago

[adbe 3328193] Cannot unfocus Flash plugin running in protected mode by clicking the page

Categories

(Core :: Plug-ins, defect)

All
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: ws.bugzilla, Unassigned)

References

Details

(Whiteboard: [flash-11.3])

Bug 78414 is bad enough, but Firefox 13 breaks the only work-around for that bug: it is no longer possible to click the page to unfocus a plugin like Flash.

This is still present in the nightly 16.0a1 (2012-06-07).
Yeah, this is hilarious. We now have to either click (and drag) a link to take the focus back, or Alt-Tab away and then back. Presumably in version 17 these will stop working too, and then we’ll have to close and restart Firefox each time we want to close a YouTube tab? And in version 21 we’ll need to reboot? This is unbelievable.
(In reply to Roman from comment #0)
[...]
> it is no longer possible to click the page to unfocus a plugin like
> Flash.
> 
> This is still present in the nightly 16.0a1 (2012-06-07).

I'm unable to reproduce this with latest Nightly on Win7 x64.  Does this happen consistently?


(In reply to Timwi from comment #1)
[...]
> either click (and drag) a link to
> take the focus back, or Alt-Tab away and then back.
[...]

Thanks for posting a workaround!

What version of Firefox are you using?  What OS version?  Can you reproduce consistently?
(In reply to Tim Abraldes from comment #2)
> I'm unable to reproduce this with latest Nightly on Win7 x64.  Does this
> happen consistently?

I thought it did, but now I've noticed a slight inconsistency. More accurate STR, works every time as far as I can tell:

- Grab latest nightly (or Firefox 13)
- Create new profile
- Open http://www.youtube.com/watch?v=cLNq-tl4NcE
- Click "pause"
- Make sure the flash player has focus by pressing Tab. A yellow border will appear on one of the buttons if so. Otherwise click play/pause again.
- Click the blank background or any text (not link).
- Press Ctrl+W.

In Firefox up to 12, this resulted in the tab closing, because clicking the page removed focus from the plugin. In later versions, the plugin still has focus after this - quite visibly so, due to the yellow focus rectangle.

I'm on Win7 x64 too. Reproduced in nightly 2012-06-13.
Further info: I also couldn't reproduce this on another machine. Turns out this machine had Flash Player v11.2.202.235. Upon updating to v11.3.300.257, the problem can be reproduced easily.

That suggests it's not a regression in Firefox. Can anything be done on Firefox's side to mitigate this?
I can reproduce it (Firefox 13 + Win7x64), the problem is with Flash 11.3 which introduced protected mode in this version.
If you disable it (see bottom of http://forums.adobe.com/thread/1018071) thing work again like before, hope this helps.
Duplicate of this bug: 765589
Summary: Cannot unfocus plugin by clicking the page → Cannot unfocus Flash plugin running in protected mode by clicking the page
Duplicate of this bug: 766482
I can confirm this issue with keyboards and a Synaptics touchpad (I can't scroll the page using the touchpad because the Flash object doesn't release the focus).
Whiteboard: flash-11.3
Whiteboard: flash-11.3 → [flash-11.3]
Duplicate of this bug: 771773
Duplicate of this bug: 768802
This is an Adobe bug:  https://bugbase.adobe.com/index.cfm?event=bug&id=3223393

To quote from Adobe bug number 3223393 "Note" at 01:58:32 AM PDT Jun 27, 2012:
"I've reproduced this issue internally. While it might not be fixed in our next
 release, I recommend anyone who is affected by this issue give it a vote and
 comment on how this issue impact your developing and working so that we can
 adjust its priority accordingly."
It may well be the case that the problem was triggered by a change in Adobe’s code. It may also well be the case that it is within Adobe’s abilities to make the problem go away.

Despite, surely this is still a bug in Firefox. Firefox must not, under any circumstances, allow a plugin to compromise the ability to focus away from it by clicking outside of it. Firefox must always, without exception, send keyboard focus to the webpage when the webpage is clicked, no matter what the plugin does. The fact that plugins can break this is clearly a bug in Firefox.
Summary: Cannot unfocus Flash plugin running in protected mode by clicking the page → [adbe 3223393] Cannot unfocus Flash plugin running in protected mode by clicking the page
Component: General → Flash (Adobe)
Product: Firefox → Plugins
Version: Trunk → unspecified
The linked Adobe bug is different to the one described here. That bug is about the Firefox window losing the foreground window status. This bug is about the inability to unfocus the plugin control.

I couldn't find one for the issue described here.
Thanks for the precision. I'll check the duplicates too, maybe some ones are real dupes of this bug.
Summary: [adbe 3223393] Cannot unfocus Flash plugin running in protected mode by clicking the page → Cannot unfocus Flash plugin running in protected mode by clicking the page
Duplicate of this bug: 777765
(In reply to Roman from comment #3)
> (In reply to Tim Abraldes from comment #2)
> > I'm unable to reproduce this with latest Nightly on Win7 x64.  Does this
> > happen consistently?
> 
> I thought it did, but now I've noticed a slight inconsistency. More accurate
> STR, works every time as far as I can tell:
> 
> - Grab latest nightly (or Firefox 13)
> - Create new profile
> - Open http://www.youtube.com/watch?v=cLNq-tl4NcE
> - Click "pause"
> - Make sure the flash player has focus by pressing Tab. A yellow border will
> appear on one of the buttons if so. Otherwise click play/pause again.
> - Click the blank background or any text (not link).
> - Press Ctrl+W.
> 
> In Firefox up to 12, this resulted in the tab closing, because clicking the
> page removed focus from the plugin. In later versions, the plugin still has
> focus after this - quite visibly so, due to the yellow focus rectangle.
> 
> I'm on Win7 x64 too. Reproduced in nightly 2012-06-13.

Reproducible with Flash 114.400.252 on Nightly 17.0a1 (2012-08-07).
Reproducible on Flash 11.4.402.265 on Firefox 15.0 and 15.0.1 on 7 x64 with Synaptics 15.1.15 on a v7.4 Touchpad.

Interestingly, sometimes the bug doesn’t appear in the first few seconds of opening Firefox (this part is sometimes reproducible, sometimes not):

1. Open a Firefox tab with YouTube (or something with Flash). 
2. Close Firefox.
3. Open Firefox and the YouTube tab should reload (if you haven't disabled session restore)
4. Very quickly pause the YouTube video (thus presumably giving the plugin focus). Then click away on the page and the page regains focus!
5. It will work for a few seconds, but then the bug appears. :/
Sorry: last one! :)

https://support.mozilla.org/en-US/questions/930244

Here, I showed that Flash Player 10.2 and 10.3 do NOT exhibit this problem. :(
(In reply to Ibrahim Jadoon from comment #17)
> 1. Open a Firefox tab with YouTube (or something with Flash). 
> 2. Close Firefox.
> 3. Open Firefox and the YouTube tab should reload (if you haven't disabled
> session restore)
> 4. Very quickly pause the YouTube video (thus presumably giving the plugin
> focus). Then click away on the page and the page regains focus!
> 5. It will work for a few seconds, but then the bug appears. :/

Please, read the detailed STR provided in comment #3 because yours cover a different bug (which is probably bug 768802). In this current bug, there is no need to close Firefox or leave the tab with Flash element to steal the focus.
(In reply to Loic from comment #20)
> (In reply to Ibrahim Jadoon from comment #17)
> > 1. Open a Firefox tab with YouTube (or something with Flash). 
> > 2. Close Firefox.
> > 3. Open Firefox and the YouTube tab should reload (if you haven't disabled
> > session restore)
> > 4. Very quickly pause the YouTube video (thus presumably giving the plugin
> > focus). Then click away on the page and the page regains focus!
> > 5. It will work for a few seconds, but then the bug appears. :/
> 
> Please, read the detailed STR provided in comment #3 because yours cover a
> different bug (which is probably bug 768802). In this current bug, there is
> no need to close Firefox or leave the tab with Flash element to steal the
> focus.

OK, whatever, you're right, I don't know, maybe I have both bugs....OK, sorry for being terse, but I HAVE AMAZING NEWS!!! I FOUND A WAY TO FIX THE BUG, at least on my system.

Workaround:

- Grab latest nightly (or Firefox 13)
- Create new profile [or use whatever profile you have now; it worked on new ones for me and my normal]
- Open http://www.youtube.com/watch?v=cLNq-tl4NcE
- Click "pause"
- Make sure the flash player has focus by pressing Tab. A yellow border will appear on one of the buttons if so. Otherwise click play/pause again.
- Click the blank background or any text (not link).
- NEW: Now, click repeatedly on the blank background and scroll at the same time (it shouldn't work initially). But after furiously clicking and scrolling for a few seconds, the yellow box disappears and you have focus back!
- Press Ctrl+W.
- And the tab will close.

You may be saying: well, that's a hard workaround; why should I have to click/scroll many times? BUT THE FIX IS PERMANENT! Now, you just have to click once in the page you get focus back.

Don't ask me why this works...but I was frustrated, lol, and had the usual "hit all the keys hard" thought process.

I've confirmed it twice, each time with a new profile! Does this work for anyone else? I can make a YouTube video, if you guys want (but I need a screencasting tool that records "clicks," if you have suggestions?!). Ahhh, too excited! :)
we can reproduce and are tracking the work internally in #3328193.
Status: NEW → ASSIGNED
Summary: Cannot unfocus Flash plugin running in protected mode by clicking the page → [adbe 3328193] Cannot unfocus Flash plugin running in protected mode by clicking the page
(In reply to smadayag from comment #22)
> we can reproduce and are tracking the work internally in #3328193.

Great, thanks! :) Is the bug reproducible or is my fix reproducible, out of curiosity?
He was speaking about the bug.
Is this issue specific to Flash? I am seeing the exact same behavior with Java applets embedded in a webpage. Doesn't this bug apply to *all* plugins?
This bug is specific to Flash. Java has some issues, but they are caused by a different kind of multiprocess issue.
Can someone from Adobe (or Mozilla) confirm Flash steals the focus of Firefox controls (like keyboard keys, mouse wheel scrolling, shortcuts etc)?

In fact, I'm meeting a similar issue of this bug since a few days. It appeared suddenly with Flash 11.4 then with Flash 11.5 now. Disabling protected mode (by adding ProtectedMode=0 into mms.cfg file) does NOT help.

STR:
1) Open any Youtube videos
2) Click on play and seek into the video
3) Go t another tab

Result:
I can't type anymore in the location bar, mouse wheel scrolling doesn't work.

I have to minimize/remaximize the Firefox window or switch to another application window to give the focus back to Firefox.

I found a regression range since FF12.
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=964b118ac852&tochange=3eaa7d9f1c69

The weird thing is it appeared suddenly friday... (no new profile or addons, no Windows updates)
Unsure, Loic. Yours might be bug 78414 (https://bugzilla.mozilla.org/show_bug.cgi?id=78414). I do not experience that bug.

--

Any status updates on this bug? I'm on 17.0.1 and it still occurs. :(
(In reply to Ibrahim Jadoon from comment #28)
> Unsure, Loic. Yours might be bug 78414
> (https://bugzilla.mozilla.org/show_bug.cgi?id=78414). I do not experience
> that bug.

Thanks but I resolved it. It was about:config > focusmanager.testmode = true (changed by mozregression tool). And indeed, it's probably bug 78414. Setting to false fixed the issue.
1) Hold the phone.  This bug has not been assigned correctly! Adbe 3223393 refers to a totally separate problem: in 3223393, the bug appears every 180 seconds (in 764390, it appears immediately), the focus is given to an imaginary window (in 764390, focus is clearly given to the Flash plugin), and a mouse-click restores focus (in 764390, a mouse-click does not restore focus). 

Adbe 3223393 ≠ Bugzilla 764390

2) And...whatever Adobe is doing, isn't this a Firefox issue, too? As Timwi said (back in...wow...July 2012!): "Despite, surely this is still a bug in Firefox. Firefox must not, under any circumstances, allow a plugin to compromise the ability to focus away from it by clicking outside of it. Firefox must always, without exception, send keyboard focus to the webpage when the webpage is clicked, no matter what the plugin does. The fact that plugins can break this is clearly a bug in Firefox."

Thus, I disabled Protected Mode. However, with all the security exploits with plugins (the debacle that is still happening with Java), I'd rather wish I didn't have to do this. :(
Sorry, wait, wrong Adobe bug. Adobe 3328193 doesn't exist! Eghad, what is going on here?
I am unable to repo this as given in comment #3 
Tested on Win7 x64
Today's Nightly build:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130131 Firefox/21.0

Latest beta Flash:
11.6.602.161
Confirmed, Firefox 34.0.5 -no-remote new profile, Flash version 15.0.0.246. Funny thing, it does not always happen.

For example, loading Youtube, the first time you try to unfocus, it requires dragging or url-bar. From then on, you can merely click on any text to unfocus. I'm not sure if the first is always right, but the second is not always correct, and I think it might sometimes bug even after loading.

I don't think I exactly want to look such an enormous browser issue related to the interfacing of two massive pieces of software, given the amount of time it takes and my familiarity with large SW proj's, and my priorities. But can confirm (sometimes).
Component: Flash (Adobe) → Plug-ins
Product: Plugins → Core
Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.