[devtb] Implement the style for the buttons in the developer toolbar

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: paul, Assigned: paul)

Tracking

Trunk
Firefox 16
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Assignee)

Description

5 years ago
The latest mockup is: https://bug744906.bugzilla.mozilla.org/attachment.cgi?id=614521
(Assignee)

Updated

5 years ago
Assignee: nobody → paul
(Assignee)

Comment 1

5 years ago
Created attachment 634831 [details]
mockup

icons will come later
I think we're going to need to think about prompts. I think that having > for the console and >> for the command line is too subtle.

In an ideal world, I'd like to use { for the console (or anywhere that takes JavaScript) because { is the closest thing to how you start writing JS. But that could be confusing.

Maybe we should just use $ or something for commands.
(Assignee)

Comment 3

5 years ago
Created attachment 635688 [details]
screenshot work in progress
Attachment #635688 - Flags: ui-review?(shorlander)
(Assignee)

Comment 4

5 years ago
Created attachment 635745 [details] [diff] [review]
v1

not test on linux and windows yet, but should be ok.
(Assignee)

Comment 5

5 years ago
Created attachment 636262 [details] [diff] [review]
v1.1
(Assignee)

Updated

5 years ago
Attachment #635745 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #635688 - Flags: ui-review?(shorlander)
(Assignee)

Comment 6

5 years ago
Comment on attachment 636262 [details] [diff] [review]
v1.1

This patch includes 4 icons (in tools-icons-small.png). The debugger icon is not yet finished. So I used the WebConsole icon as a placeholder. This will be fixed in bug 760446.
Attachment #636262 - Flags: review?(dao)
(Assignee)

Updated

5 years ago
Depends on: 763932
(Assignee)

Updated

5 years ago
Blocks: 764746
(Assignee)

Comment 7

5 years ago
Created attachment 636721 [details] [diff] [review]
v1.1

rebased
(Assignee)

Updated

5 years ago
Attachment #636262 - Attachment is obsolete: true
Attachment #636262 - Flags: review?(dao)
(Assignee)

Updated

5 years ago
Attachment #636721 - Flags: review?(dao)
(Assignee)

Comment 8

5 years ago
Created attachment 636730 [details] [diff] [review]
v1.2

debugger icon
(Assignee)

Updated

5 years ago
Attachment #636721 - Attachment is obsolete: true
Attachment #636721 - Flags: review?(dao)
(Assignee)

Updated

5 years ago
Attachment #636730 - Flags: review?(dao)
(Assignee)

Updated

5 years ago
Duplicate of this bug: 760446
(Assignee)

Updated

5 years ago
Blocks: 765564
(Assignee)

Comment 10

5 years ago
review ping

Updated

5 years ago
Attachment #636730 - Flags: review?(dao) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 11

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/650c5a98c137
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/650c5a98c137
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
You need to log in before you can comment on or make changes to this bug.