The default bug view has changed. See this FAQ.

[devtb] style the error counter

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: paul, Assigned: paul)

Tracking

Trunk
Firefox 16
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 5 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → paul
(Assignee)

Comment 1

5 years ago
Created attachment 636290 [details]
screenshot work in progress

Basic approach: we replace the icon with the counter.
(Assignee)

Comment 2

5 years ago
Created attachment 636292 [details] [diff] [review]
v1
(Assignee)

Comment 3

5 years ago
Created attachment 636293 [details] [diff] [review]
v1.1
(Assignee)

Updated

5 years ago
Attachment #636292 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
Created attachment 636294 [details]
screenshot: what if we make the text red too?
(Assignee)

Updated

5 years ago
Depends on: 764555
(Assignee)

Updated

5 years ago
Attachment #636293 - Flags: review?(dao)
(Assignee)

Comment 5

5 years ago
Comment on attachment 636293 [details] [diff] [review]
v1.1

(wrong patch, sorry)
Attachment #636293 - Flags: review?(dao)
(Assignee)

Comment 6

5 years ago
Created attachment 636719 [details] [diff] [review]
v1.2
(Assignee)

Updated

5 years ago
Attachment #636293 - Attachment is obsolete: true
(Assignee)

Comment 7

5 years ago
Comment on attachment 636719 [details] [diff] [review]
v1.2

Can you please review the devtools code?
Attachment #636719 - Flags: review?(mihai.sucan)
(Assignee)

Comment 8

5 years ago
Comment on attachment 636719 [details] [diff] [review]
v1.2

I need a browser review too!
Attachment #636719 - Flags: review?(dao)
(Assignee)

Comment 9

5 years ago
For some reasons, I forgot to add "-moz-box-pack:center" to the pseudo element.
I will add that after the reviews.
Comment on attachment 636719 [details] [diff] [review]
v1.2

Patch looks fine and UI is awesome. I like the toolbar changes. It looks much better.

The :( smiley doesn't show. I get:

Error: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIStringBundle.GetStringFromName]
Source File: resource:///modules/devtools/DeveloperToolbar.jsm
Line: 500


Giving the patch r+ but please fix this.
Attachment #636719 - Flags: review?(mihai.sucan) → review+
(Assignee)

Comment 11

5 years ago
Created attachment 636897 [details] [diff] [review]
v1.3

mssing entry in jar.mn
(Assignee)

Updated

5 years ago
Attachment #636719 - Attachment is obsolete: true
Attachment #636719 - Flags: review?(dao)
(Assignee)

Updated

5 years ago
Attachment #636897 - Flags: review?(dao)
Comment on attachment 636897 [details] [diff] [review]
v1.3

>+# The error counter is located in front of the Web Console button in the developer
>+# toolbar. This counter can only hold 2 characters.

Why can it only hold 2 characters?
(Assignee)

Comment 13

5 years ago
(In reply to Dão Gottwald [:dao] from comment #12)
> Comment on attachment 636897 [details] [diff] [review]
> v1.3
> 
> >+# The error counter is located in front of the Web Console button in the developer
> >+# toolbar. This counter can only hold 2 characters.
> 
> Why can it only hold 2 characters?

Technically, it can. But I don't want the counter to grow and move all the buttons when it reaches 100. I want the counter to look like it replaces the icon.
":(" is a nice gimmick, but not very informative or self-explanatory. Between this and the counter growing slightly when reaching 100, I think the latter is preferable. "99+" would be ok too, but of course this has the same problem that you tried to avoid.
(Assignee)

Comment 15

5 years ago
Created attachment 637107 [details] [diff] [review]
v1.4
(Assignee)

Updated

5 years ago
Attachment #636897 - Attachment is obsolete: true
Attachment #636897 - Flags: review?(dao)
(Assignee)

Updated

5 years ago
Attachment #637107 - Flags: review?(dao)
(Assignee)

Comment 16

5 years ago
review ping
Comment on attachment 637107 [details] [diff] [review]
v1.4

>+#developer-toolbar-webconsole[error-count]:before {
>+  content: attr(error-count);
>+  display: -moz-box;
>+  -moz-box-pack: center;

This part should probably be in a content stylesheet.
Attachment #637107 - Flags: review?(dao) → review+
(Assignee)

Comment 18

5 years ago
Created attachment 639345 [details] [diff] [review]
v1.5

thank you Dao.
(Assignee)

Updated

5 years ago
Attachment #637107 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 19

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/7c1d395ebab7
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/7c1d395ebab7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
Depends on: 777569
Depends on: 781291
You need to log in before you can comment on or make changes to this bug.