764746 - [devtb] style the error counter

Status: RESOLVED FIXED

(DevTools :: General, defect)

Comment 1

[Paul Rouget [:paul]]

Attachment: screenshot work in progress

Basic approach: we replace the icon with the counter.

Comment 2

[Paul Rouget [:paul]]

Attachment: v1

Comment 3

[Paul Rouget [:paul]]

Attachment: v1.1

Comment 4

[Paul Rouget [:paul]]

Attachment: screenshot: what if we make the text red too?

Comment 5

[Paul Rouget [:paul]]

Comment on attachment 636293 [details] [diff] [review]
v1.1

(wrong patch, sorry)

Comment 6

[Paul Rouget [:paul]]

Attachment: v1.2

Comment 7

[Paul Rouget [:paul]]

Comment on attachment 636719 [details] [diff] [review]
v1.2

Can you please review the devtools code?

Comment 8

[Paul Rouget [:paul]]

Comment on attachment 636719 [details] [diff] [review]
v1.2

I need a browser review too!

Comment 9

[Paul Rouget [:paul]]

For some reasons, I forgot to add "-moz-box-pack:center" to the pseudo element.
I will add that after the reviews.

Comment 10

[Mihai Sucan [:msucan]]

Comment on attachment 636719 [details] [diff] [review]
v1.2

Patch looks fine and UI is awesome. I like the toolbar changes. It looks much better.

The :( smiley doesn't show. I get:

Error: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIStringBundle.GetStringFromName]
Source File: resource:///modules/devtools/DeveloperToolbar.jsm
Line: 500


Giving the patch r+ but please fix this.

Comment 11

[Paul Rouget [:paul]]

Attachment: v1.3

mssing entry in jar.mn

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 636897 [details] [diff] [review]
v1.3

>+# The error counter is located in front of the Web Console button in the developer
>+# toolbar. This counter can only hold 2 characters.

Why can it only hold 2 characters?

Comment 13

[Paul Rouget [:paul]]

(In reply to Dão Gottwald [:dao] from comment #12)
> Comment on attachment 636897 [details] [diff] [review]
> v1.3
> 
> >+# The error counter is located in front of the Web Console button in the developer
> >+# toolbar. This counter can only hold 2 characters.
> 
> Why can it only hold 2 characters?

Technically, it can. But I don't want the counter to grow and move all the buttons when it reaches 100. I want the counter to look like it replaces the icon.

Comment 14

[Dão Gottwald [:dao]]

":(" is a nice gimmick, but not very informative or self-explanatory. Between this and the counter growing slightly when reaching 100, I think the latter is preferable. "99+" would be ok too, but of course this has the same problem that you tried to avoid.

Comment 15

[Paul Rouget [:paul]]

Attachment: v1.4

Comment 16

[Paul Rouget [:paul]]

review ping

Comment 17

[Dão Gottwald [:dao]]

Comment on attachment 637107 [details] [diff] [review]
v1.4

>+#developer-toolbar-webconsole[error-count]:before {
>+  content: attr(error-count);
>+  display: -moz-box;
>+  -moz-box-pack: center;

This part should probably be in a content stylesheet.

Comment 18

[Paul Rouget [:paul]]

Attachment: v1.5

thank you Dao.

Comment 19

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/7c1d395ebab7

Comment 20

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/7c1d395ebab7