IonMonkey: Increase maximum inlining depth

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 633486 [details] [diff] [review]
Patch

We need this for Kraken imaging-darkroom. On top of bug 762480 and bug 764923, this allows us to hoist a loop-invariant Math.log call in an inlined function.

As we discussed yesterday, we should also have some heuristics to limit the script size (and/or the total number of ops we inline), but since you're working on that I just went for the simplest fix here.
Attachment #633486 - Flags: review?(kvijayan)
Comment on attachment 633486 [details] [diff] [review]
Patch

Review of attachment 633486 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.  kraken-darkroom shows close to a 20% gain.
Attachment #633486 - Flags: review?(kvijayan) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/4a302a0e2eb3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.