Closed Bug 765208 Opened 12 years ago Closed 11 years ago

IonMonkey: Increase maximum inlining depth

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch
703 bytes, patch
djvj
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
We need this for Kraken imaging-darkroom. On top of bug 762480 and bug 764923, this allows us to hoist a loop-invariant Math.log call in an inlined function.

As we discussed yesterday, we should also have some heuristics to limit the script size (and/or the total number of ops we inline), but since you're working on that I just went for the simplest fix here.
Attachment #633486 - Flags: review?(kvijayan)
Comment on attachment 633486 [details] [diff] [review]
Patch

Review of attachment 633486 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.  kraken-darkroom shows close to a 20% gain.
Attachment #633486 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/4a302a0e2eb3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.