765770 - `make test` fails (FAIL: test_password_reset ; FAIL: test_password_reset_direct)

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[liebundartig]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20100101 Firefox/12.0
Build ID: 20120424151700

Steps to reproduce:

-installed CentOS 6.2 server
-followed steps at http://docs.services.mozilla.com/howtos/run-sync.html
$ hg clone https://hg.mozilla.org/services/server-full
$ cd server-full
$ make build
which works fine:
...
  Now building the app itself                                                                  [ok]
                                                                                               [done]
However the following fails:
$ make test


Actual results:

[root@ffsync server-full]# make test
bin/nosetests -s --with-xunit deps/server-core/services/tests deps/server-reg/syncreg/tests deps/server-storage/syncstorage/tests
....................................................................S..........S.S..S............................................./opt/mozilla/server-full/deps/server-reg/syncreg/tests/functional/support.py:92: DeprecationWarning: Method SQLUser.delete_user should be passed a dict of credentials, not a raw password
  self.auth.delete_user(self.user, self.password)
./opt/mozilla/server-full/deps/server-reg/syncreg/controllers/user.py:259: DeprecationWarning: Method SQLUser.update_field should be passed a dict of credentials, not a raw password
  'mail', email):
./opt/mozilla/server-full/deps/server-reg/syncreg/controllers/user.py:309: DeprecationWarning: Method SQLUser.update_password should be passed a dict of credentials, not a raw password
  new_password):
../opt/mozilla/server-full/deps/server-reg/syncreg/tests/functional/test_user.py:349: DeprecationWarning: Method SQLUser.delete_user should be passed a dict of credentials, not a raw password
  self.auth.delete_user(User(name), 'x' * 9)
./opt/mozilla/server-full/deps/server-reg/syncreg/controllers/user.py:403: DeprecationWarning: Method SQLUser.delete_user should be passed a dict of credentials, not a raw password
  res = self.auth.delete_user(request.user, request.user_password)
....FF.../opt/mozilla/server-full/deps/server-reg/syncreg/tests/functional/test_user.py:537: DeprecationWarning: Method SQLUser.delete_user should be passed a dict of credentials, not a raw password
  self.auth.delete_user(User(name), 'x' * 9)
.......................................................
======================================================================
FAIL: test_password_reset (syncreg.tests.functional.test_user.TestUser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/mozilla/server-full/deps/server-reg/syncreg/tests/functional/test_user.py", line 222, in test_password_reset
    self.assertTrue('Key does not match with username' in res)
AssertionError

======================================================================
FAIL: test_password_reset_direct (syncreg.tests.functional.test_user.TestUser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/mozilla/server-full/deps/server-reg/syncreg/tests/functional/test_user.py", line 121, in test_password_reset_direct
    self.assertTrue(e.args[0].endswith(str(ERROR_INVALID_USER)))
AssertionError

----------------------------------------------------------------------
Ran 199 tests in 29.317s

FAILED (SKIP=4, failures=2)
make: *** [test] Error 1



Expected results:

all tests should pass without problems


Is this the reason the password-reset-website does not work for my sync server?
https://mail.mozilla.org/pipermail/services-dev/2012-June/001467.html

Comment 1

[James Bonacci [:jbonacci]]

These 'make test' issues look familiar.
Will look into this with the Dev team...

Comment 2

[Ryan Kelly [:rfkelly]]

> These 'make test' issues look familiar.

Indeed.  This issue was fixed in trunk, but not included in a release tag.  I've made a new tag, please do another `make build` in your server-full directory and try the tests again.

> Is this the reason the password-reset-website does not work for my sync server?
> https://mail.mozilla.org/pipermail/services-dev/2012-June/001467.html

It's not likely to be directly related, but the new tag includes a handful of other fixes which might relate to the problems you were seeing.

Comment 3

[Ryan Kelly [:rfkelly]]

I'm resolving this FIXED since a fresh server-full checkout now passes all tests for me.  James, please try a clean checkout, make build, make test of server-full to verify.

Comment 4

[liebundartig]

after
$ make build

$ make test
is fine but has some warnings

[root@ffsync server-full]# make test 
bin/nosetests -s --with-xunit deps/server-core/services/tests deps/server-reg/syncreg/tests deps/server-storage/syncstorage/tests
....................................................................S..........S.S..S............................................./opt/mozilla/server-full/deps/server-reg/syncreg/tests/functional/support.py:92: DeprecationWarning: Method SQLUser.delete_user should be passed a dict of credentials, not a raw password
  self.auth.delete_user(self.user, self.password)
./opt/mozilla/server-full/deps/server-reg/syncreg/controllers/user.py:278: DeprecationWarning: Method SQLUser.update_field should be passed a dict of credentials, not a raw password
  'mail', email):
./opt/mozilla/server-full/deps/server-reg/syncreg/controllers/user.py:328: DeprecationWarning: Method SQLUser.update_password should be passed a dict of credentials, not a raw password
  new_password):
../opt/mozilla/server-full/deps/server-reg/syncreg/tests/functional/test_user.py:343: DeprecationWarning: Method SQLUser.delete_user should be passed a dict of credentials, not a raw password
  self.auth.delete_user(User(name), 'x' * 9)
./opt/mozilla/server-full/deps/server-reg/syncreg/controllers/user.py:424: DeprecationWarning: Method SQLUser.delete_user should be passed a dict of credentials, not a raw password
  res = self.auth.delete_user(request.user, request.user_password)
........./opt/mozilla/server-full/deps/server-reg/syncreg/tests/functional/test_user.py:531: DeprecationWarning: Method SQLUser.delete_user should be passed a dict of credentials, not a raw password
  self.auth.delete_user(User(name), 'x' * 9)
.......................................................
----------------------------------------------------------------------
Ran 199 tests in 29.194s

OK (SKIP=4)



with a fresh checkout I get the warnings as well

anyway e-mail problems persist so it must be a problem on my end and is unrelated to this bug report

Comment 5

[James Bonacci [:jbonacci]]

I will give this a try soon and see if I can duplicate the SKIP messages...

Comment 6

[James Bonacci [:jbonacci]]

If you do the following, you will get the skips, but no more warnings:
make build CHANNEL=dev

Comment 7

[James Bonacci [:jbonacci]]

Actually, with CHANNEL=dev, I still see deprecation warnings and skips.
:rfkelly, what is the correct behavior for CHANNEL=prod vs. CHANNEL=dev?

Comment 8

[Ryan Kelly [:rfkelly]]

The skips are expected, they're for testing things like the LDAP auth backend which you probably don't have configured on your machine.  They will get run by jenkins.

The deprecation warnings are expected, but annoying and now pretty pointless, so I've filed Bug 787839 to get rid of them.

Since we just made a bunch of new tags, I would expect to see no substantial difference between CHANNEL=prod and CHANNEL=dev at the moment.  There should only be a difference if we've recently fixed a bug but it has not yet been included in a release tag.

Comment 9

[James Bonacci [:jbonacci]]

Very good.