765789 - An error occurred updating the cmd_saveAsTemplate command: TypeError: gMessageBrowser.contentPrincipal.URI is null

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Philip Chee]

Tue Jun 19 2012 00:06:00
Error: An error occurred updating the cmd_saveAsTemplate command: TypeError: gMessageBrowser.contentPrincipal.URI is null
Source file: chrome://global/content/globalOverlay.js
Line: 92

I get this quite often since I have the message pane hidden (F8)

http://hg.mozilla.org/comm-central/annotate/cff415a502cb/suite/mailnews/mail3PaneWindowCommands.js#l263

263         var target = gMessageBrowser.contentPrincipal.URI.scheme;

This line fails because gMessageBrowser.contentPrincipal.URI is null.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Fixed error when updating the cmd_saveAsTemplate command. (v1)

Comment 2

[Ian Neal]

Comment on attachment 635211 [details] [diff] [review]
Fixed error when updating the cmd_saveAsTemplate command. (v1)

>       case "cmd_saveAsTemplate":
>+        var msgFolder = GetSelectedMsgFolders();
>+        var target = msgFolder[0].server.localStoreType;
>         if (GetNumSelectedMessages() > 1 || target == "news")
>           return false;   // else fall thru
Why can't we save a news message as a template? TB appears to allow it looking at their code, will test to confirm soon.

Comment 3

[Ian Neal]

(In reply to Ian Neal from comment #2)
> Comment on attachment 635211 [details] [diff] [review]
> Fixed error when updating the cmd_saveAsTemplate command. (v1)
> 
> >       case "cmd_saveAsTemplate":
> >+        var msgFolder = GetSelectedMsgFolders();
> >+        var target = msgFolder[0].server.localStoreType;
> >         if (GetNumSelectedMessages() > 1 || target == "news")
> >           return false;   // else fall thru
> Why can't we save a news message as a template? TB appears to allow it
> looking at their code, will test to confirm soon.
Hmmm, they allow it but it silently fails :(

Comment 4

[Philip Chee]

> Hmmm, they allow it but it silently fails :(
Please file a Thunderbird bug on this issue.

Comment 5

[Ian Neal]

(In reply to Philip Chee from comment #4)
> > Hmmm, they allow it but it silently fails :(
> Please file a Thunderbird bug on this issue.

Logged as bug 771777

Comment 6

[Edmund Wong (:ewong)]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/eca74a832489