765941 - [tablet] Thumbnail doesn't update after following a links to an HTTP redirect

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

I noticed this while working on bug 765805, but it turns out to be a problem even without those patches.  Steps to reproduce:

1. In native Fennec on a tablet, open http://limpet.net/mbrubeck/
2. Open the tab sidebar.
3. Tap on the "Mozilla" link in the first paragraph on the page.

Expected results: http://www.mozilla.org/en-US/firefox/fx/ opens.

Actual results:  http://www.mozilla.org/en-US/firefox/fx/ opens but the tab thumbnail does not update.

This happens because GeckoApp.handleDocumentStop compares the URI from the StateChange message to the URI from the LocationChange message.  However, the StateChange message uses the originalURI, so this breaks when there is a redirect.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

What we really want to do here is make sure the same document is still loaded once the timeout fires.  Instead of comparing the URI we get from the StateChange message, we should just get the URI from the tab before and after.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 634221 [details] [diff] [review]
patch

Should the uri parameter be removed from handleDocumentStop since it is no longer used?

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 634221 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 739407
User impact if declined: Thumbnails in tab sidebar show the wrong page after navigating to certain URLs.
Testing completed (on m-c, etc.): Landed on inbound June 19
Risk to taking this patch (and alternatives if risky): Very low-risk two-line mobile-only fix.
String or UUID changes made by this patch: None.

(In reply to Brian Nicholson (:bnicholson) from comment #2)
> Should the uri parameter be removed from handleDocumentStop since it is no
> longer used?

Good idea; done.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a2aa554c055

Comment 4

[Alex Keybl [:akeybl]]

Comment on attachment 634221 [details] [diff] [review]
patch

[Triage Comment]
Tablet UI bugs are approved for Aurora 15, as they carry little risk to mobile and none to desktop.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1a2aa554c055

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/909db3380762

Comment 7

[Paul Feher]

Verified/fixed on:
Nightly Fennec 16.0a1 (2012-07-11)
Aurora Fennec 15.0a2 (2012-07-11)
Using:
Samsung Galaxy Tab (3.1)

The tab thumbnail is updated now.