76602 - mozilla/modules/plugin folder needs revising

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P2)

Description

[av (gone)]

mozilla/modules/plugin is currently kind of messy. It has been suggested that we  
probably shouldn't make any additions to it before we bring it to some order. I 
have new samples to check in as well as bugs in the spy tool, some stuff I just 
moved from 0.9 so it is pretty urgent, and thus would really like to have the 
issue resolved.

Here is the current structure:

plugins/
  |
  +---- bad/
  +---- default/
  +---- macbuild/
  +---- mpdk/
  +---- nglsrc/
  +---- npspy/
  +---- public/
  +---- SanePlugin/
  +---- test/
  +---- testevents/

After a discussion via e-mail with some of the people on the cc list we came up 
with the following layout which will supposedly make everyone happy:

plugins
  |
  +---- base/
  |       +---- public/
  |       +---- src/ (currently ``nglsrc/'')
  |       +---- macbuild/
  |
  +---- samples/
  |       +---- default/
  |       +---- SanePlugin/
  |       +---- simple/ (currently ``test/'')
  |       +---- testevents/
  |       +---- backward/ (currently ``bad/'')
  |       +---- 4x-scriptable/ (this one is impatiently waiting)
  |
  +---- tools
          +---- mpdk/
          +---- spy/ (currently ``npspy/'')

Assigning to myself but expect somebody from the build team at least give me 
detailed instructions.

Comment 1

[av (gone)]

Setting dependencies.

Comment 2

[Daniel (Leaf) Nunes]

targetting for 0.9.1, av, i'll have to do some repository copies to make this 
happen and keep history (which, i assume, you care about).

Comment 3

[av (gone)]

This is great. Thanks, leaf. Does it mean we should imply a 'freeze' between you 
back it up and the new layout checked in?

Comment 4

[Daniel (Leaf) Nunes]

a freeze would be nice, i'll try and do this by the end of this week, 0.9 is my 
priority. would a freeze that long be too painful?

Comment 5

[karnaze (gone)]

Moving to m0.9.2

Comment 6

[Peter Lubczynski]

Jonathan/Leaf, 

can this make mozilla0.9.1? The code being blocked to check-in looks like it can 
help lots of embedding partners and plugin developers.

Comment 7

[karnaze (gone)]

Moving to m0.9.3

Comment 8

[av (gone)]

leaf, I reassigning this to you as we agreed in prior e-mail exchange.

Comment 9

[Daniel (Leaf) Nunes]

yikes. i'll hop on right now.

Comment 10

[Daniel (Leaf) Nunes]

do i need to worry about people doing work in those dirs right now?

Comment 11

[Daniel (Leaf) Nunes]

also, i need mac help to get it building in the new location before we do any 
cvs removals of old stuff.

Comment 12

[Arun Ranganathan]

chances are that if peter and andrei aren't mucking around in there, nobody is,
but i'm cc'ing beard (who does Mac plugin stuff on occasion, but only
LiveConnect -- also, he can maybe help you with this) and shaver (who may nose
around in there trying to tidy up an otherwise ugly story).

Comment 13

[Daniel (Leaf) Nunes]

alright, i've done the copy. makefile cleanup to follow (and i still need mac 
help), and then we can do cvs removal of the old file locations.

Comment 14

[Daniel (Leaf) Nunes]

Attachment: unix build system changes for the new file locations.

Comment 15

[Peter Lubczynski]

Attachment: mac build script changes

Comment 16

[Peter Lubczynski]

Attachment: updated Mac plugin project files.sit

Comment 17

[Peter Lubczynski]

Attachment: super updated Mac plugin project files.sit (now including the Default plugin project)

Comment 18

[Daniel (Leaf) Nunes]

Attachment: changes to makefile.win files in modules/plugin for new locations

Comment 19

[Daniel (Leaf) Nunes]

will cc'd folk please review the attached changes?

Comment 20

[av (gone)]

r=av on Windows and Unix changes

Comment 21

[Brian Nesse (gone)]

Unless there is a really good reason for keeping it around please kill the
pluginClassic.mcp project (and it's associated files.) Other than that, the mac
changes look ok. r=bnesse.

Comment 22

[Patrick C. Beard]

No, please don't nuke pluginClassic.mcp. This is provided to run legacy, pre-
carbon plugins when the Carbon build is running on Mac OS 9.

Comment 23

[Peter Lubczynski]

I made the changes to pluginClassic.mcp anyway not realizing that the project is 
missing from the build script anyway. I'll keep my changes and won't nuke the 
files as it can't hurt.

Simon, can I get your super revie

Comment 24

[Simon Fraser [no longer active]]

sr=sfraser for mac build changes

Comment 25

[Daniel (Leaf) Nunes]

cc'ing cls, my pleas with instant messaging fell on blind eyes.

Comment 26

[cls]

sr=cls on unix build changes.

Comment 27

[Peter Lubczynski]

Mac changes are in.

Comment 28

[av (gone)]

Any news on completing this bug? Leaf, are you going to synchronize the content 
of the current two structures when you make final changes to the makefiles?

Comment 29

[Daniel (Leaf) Nunes]

i had a tree mishap today; i have a tree again and i'm doublechecking that the
build works, i'll commit when my build finishes.

Comment 30

[Daniel (Leaf) Nunes]

build system changes for windows and unix checked in.

Comment 31

[Daniel (Leaf) Nunes]

Attachment: list of files to cvs remove, just need a mac-clued review to verify macbuild removal

Comment 32

[Peter Lubczynski]

looks fine to me, I nuked all those anyway while testing my build script changes.

r=peterl

Comment 33

[av (gone)]

r=av

Comment 34

[av (gone)]

leaf, what is ./fad folder? Also, I noticed ./pdk60 directory. Is it what was 
supposed to be ./tools/mpdk? ./src also seems to be a ghost to me.

Comment 35

[Daniel (Leaf) Nunes]

if you do:
cvs co mozilla/modules/plugin
without -P, you get all the empty directories that are under plugin, so in my
careless manual cvs operations, i pulled them and they got sucked into my list
of directories to remove.

Comment 36

[Daniel (Leaf) Nunes]

cvs removal finally committed.

Comment 37

[av (gone)]

Cool! Thanks, leaf!

Comment 38

[Jon Granrose]

verified.