If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

mozilla/modules/plugin folder needs revising

VERIFIED FIXED in mozilla0.9.4

Status

SeaMonkey
Build Config
P2
normal
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: av (gone), Assigned: Daniel (Leaf) Nunes)

Tracking

Trunk
mozilla0.9.4
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments)

(Reporter)

Description

17 years ago
mozilla/modules/plugin is currently kind of messy. It has been suggested that we  
probably shouldn't make any additions to it before we bring it to some order. I 
have new samples to check in as well as bugs in the spy tool, some stuff I just 
moved from 0.9 so it is pretty urgent, and thus would really like to have the 
issue resolved.

Here is the current structure:

plugins/
  |
  +---- bad/
  +---- default/
  +---- macbuild/
  +---- mpdk/
  +---- nglsrc/
  +---- npspy/
  +---- public/
  +---- SanePlugin/
  +---- test/
  +---- testevents/

After a discussion via e-mail with some of the people on the cc list we came up 
with the following layout which will supposedly make everyone happy:

plugins
  |
  +---- base/
  |       +---- public/
  |       +---- src/ (currently ``nglsrc/'')
  |       +---- macbuild/
  |
  +---- samples/
  |       +---- default/
  |       +---- SanePlugin/
  |       +---- simple/ (currently ``test/'')
  |       +---- testevents/
  |       +---- backward/ (currently ``bad/'')
  |       +---- 4x-scriptable/ (this one is impatiently waiting)
  |
  +---- tools
          +---- mpdk/
          +---- spy/ (currently ``npspy/'')

Assigning to myself but expect somebody from the build team at least give me 
detailed instructions.
(Reporter)

Comment 1

17 years ago
Setting dependencies.
Blocks: 39936, 73430, 73436, 73874
(Assignee)

Comment 2

17 years ago
targetting for 0.9.1, av, i'll have to do some repository copies to make this 
happen and keep history (which, i assume, you care about).
Target Milestone: --- → mozilla0.9.1
(Reporter)

Comment 3

17 years ago
This is great. Thanks, leaf. Does it mean we should imply a 'freeze' between you 
back it up and the new layout checked in?
(Assignee)

Comment 4

17 years ago
a freeze would be nice, i'll try and do this by the end of this week, 0.9 is my 
priority. would a freeze that long be too painful?
Status: NEW → ASSIGNED

Comment 5

17 years ago
Moving to m0.9.2
Target Milestone: mozilla0.9.1 → mozilla0.9.2

Comment 6

17 years ago
Jonathan/Leaf, 

can this make mozilla0.9.1? The code being blocked to check-in looks like it can 
help lots of embedding partners and plugin developers.
Keywords: mozilla0.9.1

Comment 7

17 years ago
Moving to m0.9.3
Target Milestone: mozilla0.9.2 → mozilla0.9.3

Updated

17 years ago
Blocks: 88998

Updated

17 years ago
No longer blocks: 88998

Updated

17 years ago
Blocks: 88998
(Reporter)

Comment 8

16 years ago
leaf, I reassigning this to you as we agreed in prior e-mail exchange.
Assignee: av → leaf
Status: ASSIGNED → NEW
(Assignee)

Comment 9

16 years ago
yikes. i'll hop on right now.
Status: NEW → ASSIGNED
(Assignee)

Comment 10

16 years ago
do i need to worry about people doing work in those dirs right now?
Assignee: leaf → leaf
Status: ASSIGNED → NEW
(Assignee)

Comment 11

16 years ago
also, i need mac help to get it building in the new location before we do any 
cvs removals of old stuff.
Status: NEW → ASSIGNED

Comment 12

16 years ago
chances are that if peter and andrei aren't mucking around in there, nobody is,
but i'm cc'ing beard (who does Mac plugin stuff on occasion, but only
LiveConnect -- also, he can maybe help you with this) and shaver (who may nose
around in there trying to tidy up an otherwise ugly story).
(Assignee)

Comment 13

16 years ago
alright, i've done the copy. makefile cleanup to follow (and i still need mac 
help), and then we can do cvs removal of the old file locations.
(Assignee)

Comment 14

16 years ago
Created attachment 44494 [details] [diff] [review]
unix build system changes for the new file locations.

Comment 15

16 years ago
Created attachment 44553 [details] [diff] [review]
mac build script changes

Comment 16

16 years ago
Created attachment 44554 [details]
updated Mac plugin project files.sit

Comment 17

16 years ago
Created attachment 44558 [details]
super updated Mac plugin project files.sit (now including the Default plugin project)

Updated

16 years ago
Target Milestone: mozilla0.9.3 → mozilla0.9.4
(Assignee)

Comment 18

16 years ago
Created attachment 44850 [details] [diff] [review]
changes to makefile.win files in modules/plugin for new locations
(Assignee)

Comment 19

16 years ago
will cc'd folk please review the attached changes?
(Reporter)

Comment 20

16 years ago
r=av on Windows and Unix changes

Comment 21

16 years ago
Unless there is a really good reason for keeping it around please kill the
pluginClassic.mcp project (and it's associated files.) Other than that, the mac
changes look ok. r=bnesse.

Comment 22

16 years ago
No, please don't nuke pluginClassic.mcp. This is provided to run legacy, pre-
carbon plugins when the Carbon build is running on Mac OS 9.

Comment 23

16 years ago
I made the changes to pluginClassic.mcp anyway not realizing that the project is 
missing from the build script anyway. I'll keep my changes and won't nuke the 
files as it can't hurt.

Simon, can I get your super revie

Comment 24

16 years ago
sr=sfraser for mac build changes

Updated

16 years ago
Priority: -- → P2
(Assignee)

Comment 25

16 years ago
cc'ing cls, my pleas with instant messaging fell on blind eyes.

Comment 26

16 years ago
sr=cls on unix build changes.

Comment 27

16 years ago
Mac changes are in.
(Reporter)

Comment 28

16 years ago
Any news on completing this bug? Leaf, are you going to synchronize the content 
of the current two structures when you make final changes to the makefiles?
(Assignee)

Comment 29

16 years ago
i had a tree mishap today; i have a tree again and i'm doublechecking that the
build works, i'll commit when my build finishes.
(Assignee)

Comment 30

16 years ago
build system changes for windows and unix checked in.
(Assignee)

Comment 31

16 years ago
Created attachment 45364 [details]
list of files to cvs remove, just need a mac-clued review to verify macbuild removal

Comment 32

16 years ago
looks fine to me, I nuked all those anyway while testing my build script changes.

r=peterl
(Reporter)

Comment 33

16 years ago
r=av
(Reporter)

Comment 34

16 years ago
leaf, what is ./fad folder? Also, I noticed ./pdk60 directory. Is it what was 
supposed to be ./tools/mpdk? ./src also seems to be a ghost to me.
(Assignee)

Comment 35

16 years ago
if you do:
cvs co mozilla/modules/plugin
without -P, you get all the empty directories that are under plugin, so in my
careless manual cvs operations, i pulled them and they got sucked into my list
of directories to remove.
(Assignee)

Comment 36

16 years ago
cvs removal finally committed.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 37

16 years ago
Cool! Thanks, leaf!

Comment 38

16 years ago
verified.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.