npspy/common should not use win32api calls

VERIFIED FIXED in Future

Status

()

Core
Plug-ins
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: timeless, Assigned: av (gone))

Tracking

Trunk
Future
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
at least, it would seem to me that the common directory should be for common 
functions and not platform specific functions.

/modules/plugin/npspy/common/npp_gate.cpp, line 79 -- NP_GETENTRYPOINTS 
real_NP_GetEntryPoints = (NP_GETENTRYPOINTS)GetProcAddress(hLib, 
"NP_GetEntryPoints");
(Assignee)

Comment 1

17 years ago
This is a good catch. I overlooked it. Thanks. Will take care.
(Assignee)

Updated

17 years ago
Depends on: 76602

Updated

17 years ago
Target Milestone: --- → Future
(Assignee)

Comment 2

17 years ago
Created attachment 46285 [details] [diff] [review]
first try

Comment 3

17 years ago
r=peterl
(Assignee)

Comment 4

17 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

17 years ago
You're still including windowsx.h (which i suspect is windows related) and 
there's one other windowsism in logger.cpp (neither are wrapped in XP_WIN). -- 
I can file new bugs if you want.
(Assignee)

Comment 6

17 years ago
Please, do.
(Reporter)

Comment 7

17 years ago
verified fixed + filed
Bugzilla Bug 96245 Including <windowsx.h> even for non windows platforms 
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.