766164 - Reader Mode: Optimize assets used in Reader UI

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

* Only use one size of image for all DPIs?
* Run the images through a pngcrush tool to make them as small as possible?
* Make the background images smaller, so they aren't as big?

Comment 1

[Lucas Rocha (:lucasr)]

Also:
* Can we reduce the filesize of the backgrounds? They seem a bit larger and if we could save some space, I'd like to try.

Comment 2

[Lucas Rocha (:lucasr)]

(In reply to Lucas Rocha (:lucasr) from comment #0)
> * Only use one size of image for all DPIs?

About that, I experimented using xhdpi images for all DPIs. The images scale down accordingly depending on the display density. However, the down-scaling brings a slight blurriness to the edges of the icons.

It's not too bad but Ian might not be happy about it. I'll post sample screenshots.

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Screenshot (HDPI using proper images)

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Screenshot (HDPI using downscaled XHDPI images)

Comment 5

[Lucas Rocha (:lucasr)]

Ok, my take on this is that the loss of icon sharpness is not acceptable. I'll let Ian decide. I'll pngcrush all images to try cutting a few bytes from the assets anyway.

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: pngcrush all Reader assets

Comment 7

[Ian Barlow (:ibarlow)]

I agree, we've tried using one image and scaling in other cases, and it just never works right. As much as I don't enjoy making 9 versions of the same graphic (and the resulting extra file weight), it's worth having that pixel-level precision. 

Let's keep PNG-crushing if we can.

Comment 8

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/d66e9641cf78

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d66e9641cf78