Reader Mode: Optimize assets used in Reader UI

RESOLVED FIXED in Firefox 16

Status

()

Firefox for Android
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: lucasr, Unassigned)

Tracking

Trunk
Firefox 16
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
* Only use one size of image for all DPIs?
* Run the images through a pngcrush tool to make them as small as possible?
* Make the background images smaller, so they aren't as big?
(Reporter)

Comment 1

6 years ago
Also:
* Can we reduce the filesize of the backgrounds? They seem a bit larger and if we could save some space, I'd like to try.
(Reporter)

Comment 2

6 years ago
(In reply to Lucas Rocha (:lucasr) from comment #0)
> * Only use one size of image for all DPIs?

About that, I experimented using xhdpi images for all DPIs. The images scale down accordingly depending on the display density. However, the down-scaling brings a slight blurriness to the edges of the icons.

It's not too bad but Ian might not be happy about it. I'll post sample screenshots.
(Reporter)

Comment 3

6 years ago
Created attachment 635714 [details]
Screenshot (HDPI using proper images)
(Reporter)

Comment 4

6 years ago
Created attachment 635715 [details]
Screenshot (HDPI using downscaled XHDPI images)
(Reporter)

Comment 5

6 years ago
Ok, my take on this is that the loss of icon sharpness is not acceptable. I'll let Ian decide. I'll pngcrush all images to try cutting a few bytes from the assets anyway.
(Reporter)

Comment 6

6 years ago
Created attachment 635737 [details] [diff] [review]
pngcrush all Reader assets
Attachment #635737 - Flags: review?(mark.finkle)
I agree, we've tried using one image and scaling in other cases, and it just never works right. As much as I don't enjoy making 9 versions of the same graphic (and the resulting extra file weight), it's worth having that pixel-level precision. 

Let's keep PNG-crushing if we can.
Attachment #635737 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/d66e9641cf78
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
You need to log in before you can comment on or make changes to this bug.