766260 - Default icon for Webapps pointing to invalid icons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Wesley Johnston (:wesj)]

I just installed the MapsTD app from the mozilla app store. The manifest:
http://www.mapstd.com/manifest.php
{
  "version": "1.1",
  "name": "MapsTD",
  "description": "A Tower Defence game built on Google Maps. Defend your home from invading creeps!",
  "developer": {
    "name": "Duncan Barclay",
    "url": "http://dro.me.uk"
  }
}

has no icon. I'm not sure if that's an invalid manifest, but we should probably show a default one in that case? Do we look for a favicon on the site? Or just use the rocketship somehow?

Comment 1

[Jason Smith [:jsmith]]

(In reply to Wesley Johnston (:wesj) from comment #0)
> I just installed the MapsTD app from the mozilla app store. The manifest:
> http://www.mapstd.com/manifest.php
> {
>   "version": "1.1",
>   "name": "MapsTD",
>   "description": "A Tower Defence game built on Google Maps. Defend your
> home from invading creeps!",
>   "developer": {
>     "name": "Duncan Barclay",
>     "url": "http://dro.me.uk"
>   }
> }
> 
> has no icon. I'm not sure if that's an invalid manifest, but we should
> probably show a default one in that case? Do we look for a favicon on the
> site? Or just use the rocketship somehow?

It's a valid manifest (you can have no icons for an app). Desktop right now uses the red rocketship if there is no icon provided, so that's probably a good way to go. We should fix bug 749618 first though, as we don't even get a shortcut right now with apps with no icons.

Comment 2

[Jason Smith [:jsmith]]

k9o nomination - marketplace does have apps submitted that do not have icons. Right now, no icon results in just text showing up (not even a default image), which feels off. We should at least show something (probably the red rocketship).

Comment 3

[Jason Smith [:jsmith]]

Note for implementing this - make sure the default icon for webapps with no icon applies to apps not only don't specify an icon, but also apps that have paths to icons that do not exist. That will fix the issue in another bug in regards to being unable to launch apps that have icons point to non-existent locations by caveat.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

The other patch should have fixed this. Morphing this bug to handle manifests that link to a non-existent image.

We could fall back up the tree of images to find the smallest one that exists, but I think I'd rather just do this.

Comment 5

[Wesley Johnston (:wesj)]

test manifest http://hedgehog5404.testmanifest.com/

Comment 6

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81d3daf11079

Comment 7

[Aaron Train [:aaronmt]]

V-F via latest-Inbound (07/12), Samsung Galaxy Nexus (Android 4.1.1)

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/81d3daf11079

Comment 10

[Jason Smith [:jsmith]]

Aaron - Is this verified on m-c as well?

Comment 11

[Aaron Train [:aaronmt]]

Yes, (now 17).