Closed
Bug 766260
Opened 12 years ago
Closed 12 years ago
Default icon for Webapps pointing to invalid icons
Categories
(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)
Firefox for Android Graveyard
Web Apps (PWAs)
Tracking
(blocking-kilimanjaro:+, firefox16 verified, firefox17 verified)
People
(Reporter: wesj, Assigned: wesj)
References
Details
(Whiteboard: [blocking-webrtandroid1+])
Attachments
(1 file)
1.11 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
I just installed the MapsTD app from the mozilla app store. The manifest: http://www.mapstd.com/manifest.php { "version": "1.1", "name": "MapsTD", "description": "A Tower Defence game built on Google Maps. Defend your home from invading creeps!", "developer": { "name": "Duncan Barclay", "url": "http://dro.me.uk" } } has no icon. I'm not sure if that's an invalid manifest, but we should probably show a default one in that case? Do we look for a favicon on the site? Or just use the rocketship somehow?
Assignee | ||
Updated•12 years ago
|
Blocks: Blocking-FFA-WebRT1+
Comment 1•12 years ago
|
||
(In reply to Wesley Johnston (:wesj) from comment #0) > I just installed the MapsTD app from the mozilla app store. The manifest: > http://www.mapstd.com/manifest.php > { > "version": "1.1", > "name": "MapsTD", > "description": "A Tower Defence game built on Google Maps. Defend your > home from invading creeps!", > "developer": { > "name": "Duncan Barclay", > "url": "http://dro.me.uk" > } > } > > has no icon. I'm not sure if that's an invalid manifest, but we should > probably show a default one in that case? Do we look for a favicon on the > site? Or just use the rocketship somehow? It's a valid manifest (you can have no icons for an app). Desktop right now uses the red rocketship if there is no icon provided, so that's probably a good way to go. We should fix bug 749618 first though, as we don't even get a shortcut right now with apps with no icons.
Depends on: 749618
Updated•12 years ago
|
Comment 2•12 years ago
|
||
k9o nomination - marketplace does have apps submitted that do not have icons. Right now, no icon results in just text showing up (not even a default image), which feels off. We should at least show something (probably the red rocketship).
blocking-kilimanjaro: --- → ?
Updated•12 years ago
|
Flags: in-moztrap?(aaron.train)
Updated•12 years ago
|
blocking-kilimanjaro: ? → +
Comment 3•12 years ago
|
||
Note for implementing this - make sure the default icon for webapps with no icon applies to apps not only don't specify an icon, but also apps that have paths to icons that do not exist. That will fix the issue in another bug in regards to being unable to launch apps that have icons point to non-existent locations by caveat.
Assignee | ||
Comment 4•12 years ago
|
||
The other patch should have fixed this. Morphing this bug to handle manifests that link to a non-existent image. We could fall back up the tree of images to find the smallest one that exists, but I think I'd rather just do this.
Attachment #637640 -
Flags: review?(mark.finkle)
Assignee | ||
Updated•12 years ago
|
Summary: Default icon for Webapps with no icon → Default icon for Webapps pointing to invalid icons
Updated•12 years ago
|
Attachment #637640 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
No longer blocks: Blocking-FFA-WebRT1+
Updated•12 years ago
|
Blocks: Blocking-FFA-WebRT1+
Priority: -- → P1
Updated•12 years ago
|
QA Contact: aaron.train
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/81d3daf11079
Updated•12 years ago
|
Whiteboard: [qa+]
Comment 7•12 years ago
|
||
V-F via latest-Inbound (07/12), Samsung Galaxy Nexus (Android 4.1.1)
status-firefox16:
--- → verified
Whiteboard: [qa+]
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/81d3daf11079
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: [qa+]
Updated•12 years ago
|
Assignee: nobody → wjohnston
Target Milestone: --- → Firefox 16
Comment 11•12 years ago
|
||
Yes, (now 17).
Status: RESOLVED → VERIFIED
status-firefox17:
--- → verified
Updated•12 years ago
|
Whiteboard: [qa+]
Updated•12 years ago
|
Whiteboard: [blocking-webrtandroid1+]
Updated•9 years ago
|
Flags: in-moztrap?(aaron.train)
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•