766429 - Minimize the size of the offscreen surfaces created for SVG group opacity, masks and complex clipPaths

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Now that bug 734082 is fixed and we have valid visual overflow rects on both SVG leaf and container frames, we can use these rects to minimize the size of the surfaces we create for SVG group opacity, masking and complex clipping. This should be a fairly substantial perf win on some SVG demos where we performed much worse than other implementations.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

Forgot to qrefresh.

Comment 3

[Jonathan Watt [:jwatt]]

Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/74a1fc0f4859

Comment 4

[Robert Longson [:longsonr]]

It seems to me that this has made bug 614840 much more frequent

Comment 5

[Jonathan Watt [:jwatt]]

Interesting. Still, it's not due to the clip added in this patch clipping away stuff that shouldn't be clipped away. It's just an off-by-one difference to the R and B components of two pixels that are clearly well inside this additional clip, and only on Win6.1. I think we should just mark those test with fuzzy-if for that platform.

Comment 6

[Robert Longson [:longsonr]]

a 2 pixel fuzzy-if sounds good.

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/74a1fc0f4859

Comment 8

[Jonathan Watt [:jwatt]]

For me, this gave the IE Test Drive Helicopter demo in bug 608495 a huge 150x speedup.

It seems to have also fixed the freezes that occurred when interacting with the maps on genomemaps.org reported in bug 754644.