Closed Bug 766494 Opened 8 years ago Closed 8 years ago

Profile missing alert checks for the wrong missing folder

Categories

(Toolkit :: Startup and Profile System, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

The profile missing alert added in bug 278860 checks for the local folder instead of the root folder. While there are a number of cases where these folders are the same, this is not always the case, and it is only the root folder which needs to exist before the profile can be locked; the local folder does not need to be exist and will be created on demand. If you remove your root folder without removing your local folder then you will get the profile locked alert instead of the profile missing alert. Furthermore if for some reason you manage to lock your root folder while your local folder is missing then you will get the profile missing alert instead of the profile locked alert.
I'll take a look.

For the record though, all of my code was added in failure cases, so you always incorrectly got the locked alert anyway.
Attached patch Proposed patchSplinter Review
Properly detect the lack of the profile root dir, rather than the local dir.
(Only makes a difference when using a named profile on Windows/Mac.)
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #639853 - Flags: review?(benjamin)
Shouldn't you leave the local dir check in and add the root check? You'll still end up with the profile locked error if the profile dir doesn't exist.
(In reply to Michael Kaply (mkaply) from comment #3)
> Shouldn't you leave the local dir check in and add the root check? You'll
> still end up with the profile locked error if the profile dir doesn't exist.

No, the local dir is created on demand, only the root dir needs to exist.
Sorry, one more question, because this was actually the use case I was testing.

When you invoke Firefox like this:

firefox.exe -profile "E:\myprofile"

There is no root directory I believe. There is only a local dir.

So checking root dir won't work in that case. The profile is created in that directory with no subdirectories.
(In reply to Michael Kaply from comment #5)
> Sorry, one more question, because this was actually the use case I was testing.
> 
> When you invoke Firefox like this:
> 
> firefox.exe -profile "E:\myprofile"
> 
> There is no root directory I believe. There is only a local dir.

No, the same dir is used for both the root and local dir in that case.
Attachment #639853 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/4a291b930430
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: mozilla14 → mozilla16
You need to log in before you can comment on or make changes to this bug.