766753 - move unrelated startup code out of command line handler component

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

The command line handler component (CommandLineHandler.js) initializes the webapp registry and sets permissions on firstrun in addition to handling the command line.  It does this unrelated work because the work has to be done on startup, before the app is loaded, and the component seemed as good a place as any for it.

But failure in that script is catastrophic (the app can't load), whereas failure in the unrelated work isn't, so putting it into that component makes it unnecessarily failure-prone.  Thus we should move the unrelated work into its own script, f.e. a component that registers for a startup notification but implements no interface (like mobile/android/components/SafeBrowsing.js).

Comment 1

[Jason Smith [:jsmith]]

Myk - What's the priority here? Can you determine it and explain why?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

This is a code hygiene issue and thus merely nice to have.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The patch in bug 770770 happens to do this.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Fixed by the fix for bug 770770.