move unrelated startup code out of command line handler component

RESOLVED FIXED

Status

Firefox Graveyard
Webapp Runtime
P3
normal
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: myk, Assigned: myk)

Tracking

14 Branch

Details

(Whiteboard: [qa-])

(Assignee)

Description

5 years ago
The command line handler component (CommandLineHandler.js) initializes the webapp registry and sets permissions on firstrun in addition to handling the command line.  It does this unrelated work because the work has to be done on startup, before the app is loaded, and the component seemed as good a place as any for it.

But failure in that script is catastrophic (the app can't load), whereas failure in the unrelated work isn't, so putting it into that component makes it unnecessarily failure-prone.  Thus we should move the unrelated work into its own script, f.e. a component that registers for a startup notification but implements no interface (like mobile/android/components/SafeBrowsing.js).
Myk - What's the priority here? Can you determine it and explain why?
(Assignee)

Comment 2

5 years ago
This is a code hygiene issue and thus merely nice to have.

Updated

5 years ago
Priority: -- → P3

Updated

5 years ago
QA Contact: jsmith

Updated

5 years ago
status-firefox16: --- → wontfix
(Assignee)

Comment 3

5 years ago
The patch in bug 770770 happens to do this.
Assignee: nobody → myk
Status: NEW → ASSIGNED
Depends on: 770770
(Assignee)

Comment 4

5 years ago
Fixed by the fix for bug 770770.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.