766889 - Remove vestigial threading goop from XPConnect

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

Once bug 755255 lands, there's a lot of easy cleanup work that can be done. A big part of this is the removal of the map locks, which should give us a free performance boost. At the moment I'm guessing I can do it all in one patch stack, but I may split something off if it turns out that there's a bigger task in there somewhere.

Comment 2

[Bobby Holley (:bholley)]

The only thing I really see left to do here is to remove a few threadsafe things from XPConnect. Andrew, can you think of anything else?

Comment 3

[Andrew McCreight [:mccr8]]

Here are a few things I've come across:
- NS_DECL_THREADSAFE_ISUPPORTS
- NS_INTERFACE_MAP_END_THREADSAFE
- nsXPConnect::FindMainThread() is undefined and unused

I'm not really sure what to do with
    bool ClassIsThreadSafe()          GET_IT(THREADSAFE)
    bool ClassIsMainThreadOnly()      GET_IT(MAIN_THREAD_ONLY)
in XPCWrappedNativeProto.

Comment 4

[Bobby Holley (:bholley)]

(In reply to Andrew McCreight [:mccr8] from comment #3)
> I'm not really sure what to do with
>     bool ClassIsThreadSafe()          GET_IT(THREADSAFE)

This is unused now.

>     bool ClassIsMainThreadOnly()      GET_IT(MAIN_THREAD_ONLY)

I think this and the corresponding check in wrapper reparenting can just go away.

Comment 5

[Andrew McCreight [:mccr8]]

Hooray!