960715 - Remove a few vestigial thread-related things from XPConnect

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Andrew McCreight [:mccr8]]

There are two thread-related nsXPConnect methods that look like they can be removed:
  - ClassIsMainThreadOnly (bholley thinks the call can be removed)
  - FindMainThread isn't defined or used

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Remove XPCWrappedNativeProto::ClassIsMainThreadOnly.

Okay, I think with these two last patches the multithreaded stuff in XPConnect
should be gone.

https://tbpl.mozilla.org/?tree=Try&rev=12f97666cc97

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Remove nsXPConnect::FindMainThread().

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8361501 [details] [diff] [review]
part 1 - Remove XPCWrappedNativeProto::ClassIsMainThreadOnly.

Review of attachment 8361501 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/xpcprivate.h
@@ -1849,5 @@
>  #endif
>  #define GET_IT(f_) const {return !!(mClassInfoFlags & nsIClassInfo:: f_ );}
>  
>      bool ClassIsSingleton()           GET_IT(SINGLETON)
> -    bool ClassIsMainThreadOnly()      GET_IT(MAIN_THREAD_ONLY)

Time to remove nsIClassInfo::MAIN_THREAD_ONLY?

Comment 4

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/0ed69fa19314
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/2be8ad58c32e

Comment 5

[Andrew McCreight [:mccr8]]

Good point, Ms2ger.  I filed bug 961019.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ed69fa19314
https://hg.mozilla.org/mozilla-central/rev/2be8ad58c32e