766929 - NS_ABORT_IF_FALSE(mConnectionInfo->UsingSSL()) failing [websockets http proxy]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Honza Bambas (:mayhemer)]

Trying to reproduce bug 766817 with http://www.websocket.org/echo.html.  Using squid configured for authentication (standard config).  When clicking the [connect] button, I'm getting assertion failure at http://hg.mozilla.org/mozilla-central/annotate/10e019421e6b/netwerk/protocol/http/nsHttpChannel.cpp#l1002

    NS_ABORT_IF_FALSE(mConnectionInfo->UsingSSL(),
                      "SSL connect failed but not using SSL?");

Http status is 403, host is echo.websocket.org, port 80.  mSSLConnectFailed is set to 'true' on the transaction.

Candidate for bug 715905?

Comment 1

[Patrick McManus [:mcmanus]]

it might be as simple as the ABORT being superfulous. iirc websockets uses connect to make a websockets tunnel through the proxy.. That path is the failed-to-make-tunnel path.. off the top of my head the error handling is going to be the same even in the absence of SSL.. but it obviously needs more rigor than that.

Comment 2

[Jason Duell]

Attachment: fix abort.

Patrick's comment is right about the issue.  I grepped through the code to audit all uses of "SSL" and found a few other bugs, and a lot of stuff that should get renamed.  Filing separate bugs for those so we can sort out which deserve aurora/beta, if any.  Not sure if this one does, for instance (doesn't affect release builds).

Comment 3

[Jason Duell]

Whoops--since this depends on bug 713026 and that isn't making it to aurora/beta, it's moot to consider backporting this as well.

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 635841 [details] [diff] [review]
fix abort.

Review of attachment 635841 [details] [diff] [review]:
-----------------------------------------------------------------

the assert reason should be updated.. and maybe the general comments for the function too - I wouldn't go too crazy chasing the rabbit down the hole here though.

Comment 5

[Jason Duell]

Comments for the assertion and the function generally got updated in bug 767516. 

https://hg.mozilla.org/integration/mozilla-inbound/rev/4eca26d02c84

Comment 6

[Ed Morley [:emorley]]

Push backed out for M5 orange:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=d45ca69b67a3

Couldn't see you on #developers or see any try run URLs listed in-bug in the four bugs in the push, or I would have tried to find out if just part of it could have been backed out.

https://hg.mozilla.org/integration/mozilla-inbound/rev/51cff2123f45

Comment 7

[Honza Bambas (:mayhemer)]

Jason, could we land just this one single patch?

Comment 8

[Jason Duell]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b12977096b9

Comment 9

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/9b12977096b9