Last Comment Bug 767516 - Rename: s/SSLConnect/ProxyConnect/g
: Rename: s/SSLConnect/ProxyConnect/g
Product: Core
Classification: Components
Component: Networking: HTTP (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Nobody; OK to take it and work on it
Depends on: 767505 766929 767506 767512
  Show dependency treegraph
Reported: 2012-06-22 12:06 PDT by Jason Duell [:jduell] (needinfo? me)
Modified: 2012-08-24 20:05 PDT (History)
2 users (show)
jduell.mcbugs: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v1: s/SSLConnect/ProxyConnect/g (22.63 KB, patch)
2012-06-22 12:06 PDT, Jason Duell [:jduell] (needinfo? me)
mcmanus: review+
Details | Diff | Review

Description Jason Duell [:jduell] (needinfo? me) 2012-06-22 12:06:10 PDT
Created attachment 635852 [details] [diff] [review]
v1: s/SSLConnect/ProxyConnect/g

Like it says:  we shouldn't call things "SSLConnectFOO" is they also handle non-SSL CONNECTs.

Lots of renames, but no code changes.  If this spoils anyone's day by messing with patch contexts I'm happy to wait on it for a bit, but eventually I think we should rename.
Comment 1 Patrick McManus [:mcmanus] 2012-06-25 06:43:15 PDT
Comment on attachment 635852 [details] [diff] [review]
v1: s/SSLConnect/ProxyConnect/g

Review of attachment 635852 [details] [diff] [review]:

Ah - the full rabbit hole patch :) This wasn't as big as I thought it would be.
Comment 2 Jason Duell [:jduell] (needinfo? me) 2012-06-25 12:49:34 PDT
Comment 3 Ed Morley [:emorley] 2012-06-25 13:41:46 PDT
Push backed out for M5 orange:

Couldn't see you on #developers or see any try run URLs listed in-bug in the four bugs in the push, or I would have tried to find out if just part of it could have been backed out.
Comment 4 Jason Duell [:jduell] (needinfo? me) 2012-08-23 17:20:53 PDT

Green on try:

bug 767505 was the breakage.
Comment 5 Jason Duell [:jduell] (needinfo? me) 2012-08-23 17:24:11 PDT
rename, no logic changes
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-08-24 20:05:16 PDT

Note You need to log in before you can comment on or make changes to this bug.