767516 - Rename: s/SSLConnect/ProxyConnect/g

Status: RESOLVED FIXED

Description

[Jason Duell [:jduell] (needinfo me)]

Created attachment 635852 [details] [diff] [review]
v1: s/SSLConnect/ProxyConnect/g

Like it says:  we shouldn't call things "SSLConnectFOO" is they also handle non-SSL CONNECTs.

Lots of renames, but no code changes.  If this spoils anyone's day by messing with patch contexts I'm happy to wait on it for a bit, but eventually I think we should rename.

Comment 1

[Patrick McManus [:mcmanus]]

Comment on attachment 635852 [details] [diff] [review]
v1: s/SSLConnect/ProxyConnect/g

Review of attachment 635852 [details] [diff] [review]:
-----------------------------------------------------------------

Ah - the full rabbit hole patch :) This wasn't as big as I thought it would be.

Comment 2

[Jason Duell [:jduell] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d45ca69b67a3

Comment 3

[Ed Morley [:emorley]]

Push backed out for M5 orange:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=d45ca69b67a3

Couldn't see you on #developers or see any try run URLs listed in-bug in the four bugs in the push, or I would have tried to find out if just part of it could have been backed out.

https://hg.mozilla.org/integration/mozilla-inbound/rev/51cff2123f45

Comment 4

[Jason Duell [:jduell] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af4b272232b9

Green on try:

   https://tbpl.mozilla.org/?tree=Try&rev=38dcbff44cc7

bug 767505 was the breakage.

Comment 5

[Jason Duell [:jduell] (needinfo me)]

rename, no logic changes

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af4b272232b9