Status
()
People
(Reporter: jduell.mcbugs, Unassigned)
Tracking
(Depends on 1 bug)
Bug Flags:
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
22.63 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
Like it says: we shouldn't call things "SSLConnectFOO" is they also handle non-SSL CONNECTs. Lots of renames, but no code changes. If this spoils anyone's day by messing with patch contexts I'm happy to wait on it for a bit, but eventually I think we should rename.
Attachment #635852 -
Flags: review?(mcmanus)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 635852 [details] [diff] [review] v1: s/SSLConnect/ProxyConnect/g Review of attachment 635852 [details] [diff] [review]: ----------------------------------------------------------------- Ah - the full rabbit hole patch :) This wasn't as big as I thought it would be.
Attachment #635852 -
Flags: review?(mcmanus) → review+
|
Reporter | |
Comment 2•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d45ca69b67a3
|
||
Comment 3•7 years ago
|
||
Push backed out for M5 orange: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=d45ca69b67a3 Couldn't see you on #developers or see any try run URLs listed in-bug in the four bugs in the push, or I would have tried to find out if just part of it could have been backed out. https://hg.mozilla.org/integration/mozilla-inbound/rev/51cff2123f45
|
|
Reporter | |
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/af4b272232b9 Green on try: https://tbpl.mozilla.org/?tree=Try&rev=38dcbff44cc7 bug 767505 was the breakage.
OS: Linux → All
Hardware: x86_64 → All
|
||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/af4b272232b9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•