Rename: s/SSLConnect/ProxyConnect/g

RESOLVED FIXED in mozilla17

Status

()

Core
Networking: HTTP
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jduell, Unassigned)

Tracking

(Depends on: 1 bug)

unspecified
mozilla17
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 635852 [details] [diff] [review]
v1: s/SSLConnect/ProxyConnect/g

Like it says:  we shouldn't call things "SSLConnectFOO" is they also handle non-SSL CONNECTs.

Lots of renames, but no code changes.  If this spoils anyone's day by messing with patch contexts I'm happy to wait on it for a bit, but eventually I think we should rename.
Attachment #635852 - Flags: review?(mcmanus)
(Reporter)

Updated

5 years ago
Depends on: 767505
Comment on attachment 635852 [details] [diff] [review]
v1: s/SSLConnect/ProxyConnect/g

Review of attachment 635852 [details] [diff] [review]:
-----------------------------------------------------------------

Ah - the full rabbit hole patch :) This wasn't as big as I thought it would be.
Attachment #635852 - Flags: review?(mcmanus) → review+
(Reporter)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d45ca69b67a3

Comment 3

5 years ago
Push backed out for M5 orange:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=d45ca69b67a3

Couldn't see you on #developers or see any try run URLs listed in-bug in the four bugs in the push, or I would have tried to find out if just part of it could have been backed out.

https://hg.mozilla.org/integration/mozilla-inbound/rev/51cff2123f45
(Reporter)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/af4b272232b9

Green on try:

   https://tbpl.mozilla.org/?tree=Try&rev=38dcbff44cc7

bug 767505 was the breakage.
OS: Linux → All
Hardware: x86_64 → All
(Reporter)

Comment 5

5 years ago
rename, no logic changes
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/af4b272232b9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.