766966 - Change Reader Mode menu item from "Font" to "Text"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Change "Font" to "Text" in Reader UI

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 635681 [details] [diff] [review]
Change "Font" to "Text" in Reader UI

>diff --git a/mobile/android/locales/en-US/chrome/aboutReader.properties b/mobile/android/locales/en-US/chrome/aboutReader.properties

>-aboutReader.fontTitle=Font
>+aboutReader.fontTitle=Text

You'll need to change the entity name too, because some locales have already translated this string:
http://mxr.mozilla.org/l10n-central/search?string=aboutReader.fontTitle

aboutReader.textTitle=Text

or

aboutReader.fontTitle2=Text

Everyone wishes we didn't need to do this and L10N has future tools that will allow us to not do it, but for now, we need to do it.

r- since the patch we get a little bigger

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Change "Font" to "Text" in Reader UI

Comment 4

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/112547d7cb08

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/112547d7cb08

Comment 6

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 20.0b5, Firefox for Android 21.0a2 (2013-03-14) and Firefox for Android 22.0a1(2013-03-15)
-device: Samsung Galaxy Nexus
-OS: Android 4.1.1