766975 - xpcshell.o deps get clobbered on Unix platforms

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Bobby Holley (:bholley)]

I revved the IID, and xpcshell is failing on tinderbox when it tries to get nsIXPConnect, and needs a clobber.

I don't know how to do this properly. Maybe khuey can help?

Comment 1

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=12865708&tree=Mozilla-Inbound

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Whatever you're seeing is something else.  xpcshell does depend on nsIXPConnect.h.

Comment 3

[Ed Morley [:emorley]]

Why did we have to clobber then?

I'd like to stamp out these have to force clobber type issues ideally...

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

So would I, but as filed, the bug is invalid.  If we can reproduce this locally, then lets file another bug and investigate.

Comment 5

[Bobby Holley (:bholley)]

I still see this locally on mac.

STR:
1 - do a clean build
2 - rev the UUID of nsIXPConnect
3 - do a top-level make

Kyle, did you maybe give the build too many hints with your make -C?

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

No.  I did a top level make.

Can you attach objdir/js/xpconnect/shell/.deps/xpcshell.o.pp?

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Also, are you using gcc or clang?

Comment 8

[Bobby Holley (:bholley)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #6)
> No.  I did a top level make.
> 
> Can you attach objdir/js/xpconnect/shell/.deps/xpcshell.o.pp?

There is no xpcshell.o.pp. There is, however, xpcshell.pp:

xpcshell : xpcshell.o xpcshellMacUtils.o ../../../dist/lib/libxpcomglue_s.a ../../../dist/bin/XUL ../../../dist/bin/XUL

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #7)
> Also, are you using gcc or clang?

gcc.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Uh .... why on earth is there no xpcshell.o.pp?

Comment 10

[Bobby Holley (:bholley)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #9)
> Uh .... why on earth is there no xpcshell.o.pp?

You tell me. I have no idea what a pp file is.

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

It's the compiler generated dependency file.

If you make clean in js/xpconnect/shell and then make, what command is used to build xpcshell.o?

Comment 12

[Bobby Holley (:bholley)]

http://pastebin.mozilla.org/1669612

Comment 13

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Fun.

Comment 14

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

So, what happens here is that a set of deps are generated for xpcshell (the binary), which overwrite the set of deps for xpcshell.o.  This doesn't happen on Windows, since there we use the object suffix in the deps file.

Comment 15

[(not currently active) Ted Mielczarek]

Fallout from one of glandium's patches but I forget which one.

Comment 16

[Mike Hommey [:glandium]]

Ah, that'd be a fallout from bug 763893

Comment 17

[Mike Hommey [:glandium]]

Attachment: Rename OBJS-related dependency files

Comment 18

[Mike Hommey [:glandium]]

Attachment: Rename OBJS-related dependency files

This should actually work.

Comment 20

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a13e11be0959

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a13e11be0959