The default bug view has changed. See this FAQ.

xpcshell.o deps get clobbered on Unix platforms

RESOLVED FIXED in mozilla16

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bholley, Assigned: glandium)

Tracking

unspecified
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I revved the IID, and xpcshell is failing on tinderbox when it tries to get nsIXPConnect, and needs a clobber.

I don't know how to do this properly. Maybe khuey can help?
https://tbpl.mozilla.org/php/getParsedLog.php?id=12865708&tree=Mozilla-Inbound
Whatever you're seeing is something else.  xpcshell does depend on nsIXPConnect.h.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
Why did we have to clobber then?

I'd like to stamp out these have to force clobber type issues ideally...
So would I, but as filed, the bug is invalid.  If we can reproduce this locally, then lets file another bug and investigate.
I still see this locally on mac.

STR:
1 - do a clean build
2 - rev the UUID of nsIXPConnect
3 - do a top-level make

Kyle, did you maybe give the build too many hints with your make -C?
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
No.  I did a top level make.

Can you attach objdir/js/xpconnect/shell/.deps/xpcshell.o.pp?
Also, are you using gcc or clang?
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #6)
> No.  I did a top level make.
> 
> Can you attach objdir/js/xpconnect/shell/.deps/xpcshell.o.pp?

There is no xpcshell.o.pp. There is, however, xpcshell.pp:

xpcshell : xpcshell.o xpcshellMacUtils.o ../../../dist/lib/libxpcomglue_s.a ../../../dist/bin/XUL ../../../dist/bin/XUL

(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #7)
> Also, are you using gcc or clang?

gcc.
Uh .... why on earth is there no xpcshell.o.pp?
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #9)
> Uh .... why on earth is there no xpcshell.o.pp?

You tell me. I have no idea what a pp file is.
It's the compiler generated dependency file.

If you make clean in js/xpconnect/shell and then make, what command is used to build xpcshell.o?
http://pastebin.mozilla.org/1669612
Fun.
So, what happens here is that a set of deps are generated for xpcshell (the binary), which overwrite the set of deps for xpcshell.o.  This doesn't happen on Windows, since there we use the object suffix in the deps file.
Summary: xpcshell Makefile doesn't properly depend on nsIXPConnect idl → xpcshell.o deps get clobbered on Unix platforms
Status: REOPENED → NEW
Fallout from one of glandium's patches but I forget which one.
Component: XPConnect → Build Config
QA Contact: xpconnect → build-config
(Assignee)

Comment 16

5 years ago
Ah, that'd be a fallout from bug 763893
(Assignee)

Comment 17

5 years ago
Created attachment 635388 [details] [diff] [review]
Rename OBJS-related dependency files
Attachment #635388 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
Blocks: 763893
(Assignee)

Comment 18

5 years ago
Created attachment 635397 [details] [diff] [review]
Rename OBJS-related dependency files

This should actually work.
Attachment #635397 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

5 years ago
Attachment #635388 - Attachment is obsolete: true
Attachment #635388 - Flags: review?(ted.mielczarek)
Duplicate of this bug: 767422
Attachment #635397 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 20

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a13e11be0959
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/a13e11be0959
Status: NEW → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Depends on: 785622
You need to log in before you can comment on or make changes to this bug.