Closed Bug 766975 Opened 8 years ago Closed 8 years ago

xpcshell.o deps get clobbered on Unix platforms

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla16

People

(Reporter: bholley, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

I revved the IID, and xpcshell is failing on tinderbox when it tries to get nsIXPConnect, and needs a clobber.

I don't know how to do this properly. Maybe khuey can help?
Whatever you're seeing is something else.  xpcshell does depend on nsIXPConnect.h.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Why did we have to clobber then?

I'd like to stamp out these have to force clobber type issues ideally...
So would I, but as filed, the bug is invalid.  If we can reproduce this locally, then lets file another bug and investigate.
I still see this locally on mac.

STR:
1 - do a clean build
2 - rev the UUID of nsIXPConnect
3 - do a top-level make

Kyle, did you maybe give the build too many hints with your make -C?
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
No.  I did a top level make.

Can you attach objdir/js/xpconnect/shell/.deps/xpcshell.o.pp?
Also, are you using gcc or clang?
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #6)
> No.  I did a top level make.
> 
> Can you attach objdir/js/xpconnect/shell/.deps/xpcshell.o.pp?

There is no xpcshell.o.pp. There is, however, xpcshell.pp:

xpcshell : xpcshell.o xpcshellMacUtils.o ../../../dist/lib/libxpcomglue_s.a ../../../dist/bin/XUL ../../../dist/bin/XUL

(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #7)
> Also, are you using gcc or clang?

gcc.
Uh .... why on earth is there no xpcshell.o.pp?
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #9)
> Uh .... why on earth is there no xpcshell.o.pp?

You tell me. I have no idea what a pp file is.
It's the compiler generated dependency file.

If you make clean in js/xpconnect/shell and then make, what command is used to build xpcshell.o?
So, what happens here is that a set of deps are generated for xpcshell (the binary), which overwrite the set of deps for xpcshell.o.  This doesn't happen on Windows, since there we use the object suffix in the deps file.
Summary: xpcshell Makefile doesn't properly depend on nsIXPConnect idl → xpcshell.o deps get clobbered on Unix platforms
Fallout from one of glandium's patches but I forget which one.
Component: XPConnect → Build Config
QA Contact: xpconnect → build-config
Ah, that'd be a fallout from bug 763893
Attachment #635388 - Flags: review?(ted.mielczarek)
Assignee: nobody → mh+mozilla
Blocks: 763893
This should actually work.
Attachment #635397 - Flags: review?(ted.mielczarek)
Attachment #635388 - Attachment is obsolete: true
Attachment #635388 - Flags: review?(ted.mielczarek)
Duplicate of this bug: 767422
Attachment #635397 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/a13e11be0959
Status: NEW → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Depends on: 785622
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.